Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove inappropriate null-aware checking to moveAndRotate #1003

Merged
merged 2 commits into from
Sep 13, 2021
Merged

Remove inappropriate null-aware checking to moveAndRotate #1003

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33be5c5
Remove inappropriate null-aware checking
OfficiallySomeGuy Aug 29, 2021
9a0d069
Change underlying state property
OfficiallySomeGuy Aug 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/src/map/map.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ class MapControllerImpl implements MapController {
MoveAndRotateResult moveAndRotate(LatLng center, double zoom, double degree,
{String? id}) {
return _state.moveAndRotate(center, zoom, degree,
source: MapEventSource.mapController, id: id!);
source: MapEventSource.mapController, id: id);
}

@override
Expand Down Expand Up @@ -267,7 +267,7 @@ class MapState {
}

MoveAndRotateResult moveAndRotate(LatLng center, double zoom, double degree,
{required MapEventSource source, required String id}) {
{required MapEventSource source, String? id}) {
final moveSucc =
move(center, zoom, id: id, source: source, callOnMoveSink: false);
final rotateSucc =
Expand Down