-
-
Notifications
You must be signed in to change notification settings - Fork 877
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add polygon label placement options #1225
Conversation
Thanks for your PR! I'll have a proper look tomorrow :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is working great! I've commented below on something(s) that might need changing, but I'm open to suggestions :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with this either way. It tests fine. It feels like each option in certain cases is preferable when I look at it visually, so no preference on which is default.
polylabel is maybe ambiguous as an parameter, but I guess it does what it says on the tin (uses whatever polylabel calculates, which could change and not be a center...). So no strong preference either way.
Changed default `labelPlacement` mode to `polylabel`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Saw this PR about centered labels for polygons today.
I think it can be useful to add an option to place the label using Dart polylabel. It works well on both convex and concave polygons.
Example: