-
-
Notifications
You must be signed in to change notification settings - Fork 877
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix for flickering with fitbounds, moving calculations inside the lay… #1376
Conversation
Possible fix for the flickering issue #1375. Note this PR will need to proper testing, as I don't experience the issue, so can't verify this properly. I would also test things like reorientating the device, and on web and emulators as there may well be other issues introduced and this can be quite a fiddly one to fix. |
It's working fine for me |
@ibrierley You happy for this to be merged? |
Yes, but as mentioned, I could never replicate the problem, so was hard to know if this has been properly tested. I think it would be good for someone else to test if they get the chance, otherwise just go for it. |
Ok. @stx Can you also give this a test when you get a moment please? |
@JaffaKetchup Sure thing. I'll take a look at this tomorrow. |
@JaffaKetchup @ibrierley Sorry for the delay. Tested this on web and mobile and took 60 FPS captures and went through it frame by frame and it looks fixed and side-effect free! Nice work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @stx, no worries about the delay! LGTM.
Fix for flickering with fitbounds, moving calculations inside the layoutBuilder…