-
-
Notifications
You must be signed in to change notification settings - Fork 876
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Normalize num type #1482
Normalize num type #1482
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(cc @JaffaKetchup)
Thanks @TesteurManiak. Will merge after #1475. |
Ok, but I am traveling right now. I will go back tomorrow. |
I try to resolve the conflicts.
|
Significant changes since review
Thanks @tlserver, we'll try to review this quickly. |
CustomPoint<int>
is not used in this plugin explicitly: change CustomPoint to always double to avoid potential error.mapState.nonrotatedSize
andmapState.size
is always available after widget initlized: change its getter to non-nullable.CustomPoint.multiplyBy()
have same functionality asoperator *
: make as deprecated.