Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Rethrow exception in image provider if no fallbackUrl is defined #1555

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

envomer
Copy link
Contributor

@envomer envomer commented Jun 13, 2023

This MR should fix #1554.

Reason:
If no tile image exists, then retry only if a fallback url is defined. Otherwise rethrow the exception.

@JaffaKetchup JaffaKetchup self-requested a review June 13, 2023 12:58
Copy link
Member

@JaffaKetchup JaffaKetchup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

@JaffaKetchup JaffaKetchup merged commit ba51b15 into fleaflet:master Jun 13, 2023
@JaffaKetchup JaffaKetchup changed the title Change: rethrow exception if no fallback url is defined (FlutterMapNetworkImageProvider) Rethrow exception in image provider if no fallbackUrl is defined Jun 13, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Tile fallback feature throws error on failure when fallbackUrl not defined
2 participants