[Hotfix-24.11] [SCFD-3897] fix(): Use private_attribute_id to identify duplicate entity #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ity (#705) * Use private_attribute_id to identify duplicate entity * Use private_id for draft entities and name for other entities * Address comments * Add unittest to confirm draft entities with the same name is not identified as duplicates.
benflexcompute
approved these changes
Feb 10, 2025
|
Pending testing on 25.2 side and then merge |
benflexcompute
requested changes
Feb 10, 2025
benflexcompute
approved these changes
Feb 13, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use private_attribute_id to identify duplicate entity
Use private_id for draft entities and name for other entities
Address comments
Add unittest to confirm draft entities with the same name is not identified as duplicates.