Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixing missing assignment in Convex class #222

Merged
merged 1 commit into from
Jul 13, 2017

Conversation

k-okada
Copy link

@k-okada k-okada commented Jul 6, 2017

BACKPORT of #74 to fcl-0.3

requested at #74 (comment)

@jslee02 jslee02 merged commit 66745ee into flexible-collision-library:fcl-0.3 Jul 13, 2017
@rbbg
Copy link

rbbg commented Jul 21, 2017

@jslee02 I've been running into this problem with fcl 0.3.3 (Using it with ROS Indigo). Are there any plans to get this released?

@jslee02
Copy link
Member

jslee02 commented Jul 21, 2017

@rbbg, I added the tag for FCL 0.3.4 that includes this fix. I guess you would like to have debian packages of FCL 0.3.4. I can help updating the debian package at ppa:fcl-debs/ppa, but we might need help of @j-rivero for updating the ROS packages (e.g., ros-indigo-fcl).

@gavanderhoorn
Copy link

Releasing this would be great. It's a bit of a pain to have to build fcl and moveit and the rest from source just for this 'minor' (in SLOC) fix.

@gavanderhoorn
Copy link

Just ran into this one again on a different machine.

At least on current Trusty+Indigo this is still an issue.

@j-rivero @jslee02: anything we can do in the community to help you guys get this much needed fix out into a new release?

@j-rivero
Copy link
Contributor

j-rivero commented Aug 25, 2017

@j-rivero @jslee02: anything we can do in the community to help you guys get this much needed fix out into a new release?

I think it is on plate, sorry for the silence. I've never released fcl as a bloom package into Indigo before. Looking into it now. @isucan I assume that you have no time or interest to dedicate to this now, or would you prefer to do it yourself?

@gavanderhoorn
Copy link

Thanks @j-rivero.

Let me know if there is anything I can do to help.

@j-rivero
Copy link
Contributor

ros/rosdistro#15828

@gavanderhoorn If you could please test the package and a software built on top of it as soon as it reach the shadow repository, that would great. Thanks!

@gavanderhoorn
Copy link

@j-rivero: just tested this and it work fine.

Thanks for taking the time to do the release.

@j-rivero
Copy link
Contributor

Thanks for taking the time to do the release.

Thanks you for the work done to fix the problem.

@gavanderhoorn
Copy link

I didn't do it, it was all @k-okada and @uschwes.

@jslee02 jslee02 modified the milestone: FCL 0.6.0 Oct 27, 2017
@jslee02 jslee02 added this to the FCL 0.3.4 milestone Nov 10, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants