Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Response status meters for @ResponseMetered annotated service methods #34

Merged

Conversation

aakash-fk
Copy link
Contributor

No description provided.

@aakash-fk aakash-fk force-pushed the response-status-meter branch from 642dcc7 to 02b1a6a Compare April 29, 2021 16:03
Copy link
Contributor

@ToOnlyGaurav ToOnlyGaurav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make it configurable?
Can there be any performance implication?

@aakash-fk
Copy link
Contributor Author

This is already opt-in since it will only apply to service methods that the developer annotates with @ResponseMetered. For other methods, this interceptor will not be registered.

Regarding performance: From personal experience, Dropwizard meters & timers add negligible overhead even to methods that take a few microseconds.

Copy link
Contributor

@ToOnlyGaurav ToOnlyGaurav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ToOnlyGaurav ToOnlyGaurav merged commit 1ebb184 into flipkart-incubator:master Jun 4, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants