Add File Naming setting for more detailed naming #3002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skotopes
requested changes
Aug 22, 2023
m1-ins
changed the title
…roperly bump api version. FuriHal: fix RTC flag enum.
skotopes
requested changes
Aug 23, 2023
|
Un-draft when ready |
|
I believe I have addressed the issues raised in the last code review, but if there is logic/ the implementation that needs be changed specifically within the |
skotopes
approved these changes
Sep 1, 2023
skotopes
added a commit
that referenced
this pull request
Sep 17, 2023
* added filename mode setting * added furi_flag checks for when filename_mode is set * changed naming for ibutton, lfrfid and subghz * requested changes from PR * Lib: gather all naming bits and pieces under name generator module. Properly bump api version. FuriHal: fix RTC flag enum. * PR requested changes * bug fix for arg type * added functionality for other application scenes * Lib: cleanup name generator API, simplify usage. Sync API symbols. * Lib: proper size type in name_generator. Cleanup. * FuriHal: cleanup rtc api usage across firmware Co-authored-by: あく <alleteam@gmail.com>
hedger
added
UI
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new
Solved Issue #2598 (Feature Request) by adding more detail to file names through the use of a non-invasive setting named 'File Naming'.
Verification
You can check the difference by setting the filename mode to 'Default'.
Checklist (For Reviewer)