Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add support for Mifare Classic 4K SAK 0x38 ATQA 0x02, 0x04 and 0x08 #3009

Merged
merged 2 commits into from
Sep 1, 2023
Merged

Add support for Mifare Classic 4K SAK 0x38 ATQA 0x02, 0x04 and 0x08 #3009

merged 2 commits into from
Sep 1, 2023

Conversation

suaveolent
Copy link
Contributor

@suaveolent suaveolent commented Aug 24, 2023 •
edited by skotopes
Loading

What's new

Verification

  • Without this fix, the NFC application would not identify the card and display "Unknown ISO Tag"
  • Scanning with "Extra Actions" - "Read Specific Card Type" - "Read Mifare Classic" would lead to the card wrongly being identified as Mifare Classic 1k
  • With the fix the card is correctly identified in both scenarios

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@suaveolent suaveolent changed the title Add support for Mifare Classic 4k SAK 0x38 ATQA 0x02, 0x04, 0x08 Add support for Mifare Classic 4K SAK 0x38 ATQA 0x02, 0x04 and 0x08 Aug 24, 2023
@skotopes skotopes merged commit d8d2b36 into flipperdevices:dev Sep 1, 2023
skotopes added a commit that referenced this pull request Sep 17, 2023
@suaveolent @skotopes
Add support for Mifare Classic 4k SAK 0x38 ATQA 0x02, 0x04, 0x08 (#3009)
b992f07 
Co-authored-by: suaveolent <suaveolent@users.noreply.github.com>
Co-authored-by: あく <alleteam@gmail.com>
@hedger hedger added NFC NFC-related New Feature Contains an IMPLEMENTATION of a new feature labels Oct 13, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@gornekich gornekich gornekich approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@Astrrra Astrrra Awaiting requested review from Astrrra Astrrra is a code owner

Assignees
No one assigned
Labels
New Feature Contains an IMPLEMENTATION of a new feature NFC NFC-related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@suaveolent @skotopes @gornekich @hedger