Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Undo some TODO #3024

Merged
merged 14 commits into from
Sep 1, 2023
Merged

Undo some TODO #3024

merged 14 commits into from
Sep 1, 2023

Conversation

skotopes
Copy link
Member

@skotopes skotopes commented Aug 31, 2023

What's new

  • TODO FL-3519: documentation and link to source added
  • TODO FL-3506: removed, change ownership by copy is good
  • TODO FL-3505: removed, mutex alone is not going to fix issue with WPAN architecture
  • TODO FL-3500: refactored, store pin numbers in GpioPinRecord, fix gpio app crash caused by incorrect gpio_pins traversal.
  • TODO FL-3510: removed, comment added
  • TODO FL-3515: removed, questionable but ok
  • TODO FL-3498: implemented, guarding view port access with mutex.
  • TODO FL-3514: removed, yes we should
  • TODO FL-3497: removed, requires radically different settings approach
  • TODO FL-3497: impossible to fix with current memory allocator

Verification

  • Full tests, extra attention to GUI lockup and performance degradation

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@github-actions
Copy link

github-actions bot commented Aug 31, 2023

Compiled firmware for commit 181940c1:

@hedger hedger merged commit f218c41 into dev Sep 1, 2023
@hedger hedger deleted the aku/undo_todo branch September 1, 2023 01:54
@hedger hedger added the Core+Services HAL, furi & core system services label Oct 13, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Core+Services HAL, furi & core system services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants