Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[FL-3566] iButton: Return to the file selection if file is corrupted #3040

Merged
merged 2 commits into from
Sep 5, 2023
Merged

[FL-3566] iButton: Return to the file selection if file is corrupted #3040

merged 2 commits into from
Sep 5, 2023

Conversation

Astrrra
Copy link
Member

@Astrrra Astrrra commented Sep 4, 2023 •
edited by skotopes
Loading

What's new

  • The "Cannot load key file" error message leads back to the file picker instead of the main menu

Verification

  • Open a broken file and press left or back in iButton. You should be returned to the file selection menu with the cursor on that file.

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@github-actions
Copy link

github-actions bot commented Sep 4, 2023

Compiled firmware for commit a9063fc0:

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Compiled f7 firmware for commit ea22187b:

@skotopes skotopes merged commit 600b2ce into dev Sep 5, 2023
@skotopes skotopes deleted the astra/3566-ibutton-navigation-fix branch September 5, 2023 13:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

Assignees
No one assigned
Labels
Bug iButton
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Astrrra @skotopes