Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fbt: glob improvements #3117

Merged
merged 5 commits into from
Oct 6, 2023
Merged

fbt: glob improvements #3117

merged 5 commits into from
Oct 6, 2023

Conversation

hedger
Copy link
Member

@hedger hedger commented Sep 27, 2023 •
edited by skotopes
Loading

What's new

  • fbt: glob improvements, now treats entries with no special glob chars as files by default, not calling scons' globbing for them
  • that leads to less "virtual" dir nodes and files being created while performing lookup. That in certain cases made later lookups go through them, creating even more directories

Verification

  • [ Describe how to verify changes ]

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@hedger
fbt: glob improvements, now treats entries with no special glob chars…
30e6ba2 
… as files by default, not calling scons' globbing for them
@github-actions
Copy link

github-actions bot commented Sep 27, 2023 •
edited
Loading

Compiled f7 firmware for commit 542e42cb:

@skotopes skotopes merged commit d47e5ca into dev Oct 6, 2023
@skotopes skotopes deleted the hedger/glob_improvements branch October 6, 2023 07:11
@hedger hedger added Bug Build System & Scripts fbt, scripts and toolchain-related labels Oct 13, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

Assignees
No one assigned
Labels
Bug Build System & Scripts fbt, scripts and toolchain-related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hedger @skotopes