Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[FL-3627, FL-3628, FL-3631] fbt: glob & git improvements #3151

Merged
merged 12 commits into from
Oct 23, 2023
Merged

[FL-3627, FL-3628, FL-3631] fbt: glob & git improvements #3151

merged 12 commits into from
Oct 23, 2023

Conversation

hedger
Copy link
Member

@hedger hedger commented Oct 16, 2023 •
edited by skotopes
Loading

What's new

  • FL-3628 fbt: now respects optional FBT_GIT_SUBMODULE_SHALLOW environment variable. If set, checks out submodules with depth = 1
  • github: uses FBT_GIT_SUBMODULE_SHALLOW for all flows except lint & checks
  • fbt: now treats files in source lists without globbing symbols (*,?) as existing & required
  • FL-3627 fbt: always include app's icons' generated src file in list of app's sources
  • FL-3631 fbt: fail build if app's imports are missing; can be disabled with STRICT_FAP_IMPORT_CHECK=false on command line

Verification

  • Observe slightly lower build times
  • Try building apps with SDK

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@github-actions
Copy link

github-actions bot commented Oct 16, 2023 •
edited
Loading

Compiled f7 firmware for commit e2dce97c:

@hedger hedger added the Build System & Scripts fbt, scripts and toolchain-related label Oct 16, 2023
hedger added 3 commits October 16, 2023 22:08
@hedger
debug
496c2d0
@hedger
Revert "debug"
fc1043e 
This reverts commit 496c2d0.
@hedger
fbt: always compile icons' .c, even if user does not specify a proper…
e9bc73c 
… source glob; changed glob to require files at user-specified paths to exist
@hedger hedger changed the title fbt: optional shallow submodule checkout fbt: glob & git improvements Oct 16, 2023
@hedger hedger changed the title fbt: glob & git improvements [FL-3627, FL-3628] fbt: glob & git improvements Oct 16, 2023
@hedger hedger marked this pull request as ready for review October 16, 2023 23:12
@hedger hedger changed the title [FL-3627, FL-3628] fbt: glob & git improvements [FL-3627, FL-3628, FL-3631] fbt: glob & git improvements Oct 17, 2023
@skotopes skotopes merged commit 35c9034 into dev Oct 23, 2023
@skotopes skotopes deleted the hedger/optional_shallow branch October 23, 2023 09:55
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@drunkbatya drunkbatya Awaiting requested review from drunkbatya

Assignees
No one assigned
Labels
Build System & Scripts fbt, scripts and toolchain-related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hedger @skotopes