Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Storage: speedup write_chunk cli command #3173

Merged
merged 2 commits into from
Oct 30, 2023
+2 −4
Merged

Storage: speedup write_chunk cli command #3173

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58d10d2
Storage: speedup write_chunk cli command
skotopes Oct 30, 2023
426e964
Storage: handle disconnect on write_chunk correctly
skotopes Oct 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions applications/services/storage/storage_cli.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,11 +333,9 @@ static void storage_cli_write_chunk(Cli* cli, FuriString* path, FuriString* args
if(buffer_size) {
uint8_t* buffer = malloc(buffer_size);

for(uint32_t i = 0; i < buffer_size; i++) {
buffer[i] = cli_getc(cli);
}
size_t read_bytes = cli_read(cli, buffer, buffer_size);

uint16_t written_size = storage_file_write(file, buffer, buffer_size);
uint16_t written_size = storage_file_write(file, buffer, read_bytes);

if(written_size != buffer_size) {
storage_cli_print_error(storage_file_get_error(file));
Expand Down