[FL-3686] Mifare Classic fixes #3221

Astrrra · 2023-11-16T16:13:32Z

What's new

Fixed Mifare Classic emulation and Add Manually behavior to pass the new unit tests

Run the new NFC unit tests ([FL-3614] Add mifare classic emulation tests #3232), check that they all pass

github-actions · 2023-11-16T16:16:14Z

Compiled f7 firmware for commit 24b331b3:

…th it

lib/nfc/protocols/mf_classic/mf_classic.c

Astrrra added 2 commits November 16, 2023 19:25

Update Mifare Classic generators to create more accuate data

decca8f

Check the transfer buffer validity for NACK

55db56a

Astrrra changed the title ~~Mifare Classic fixes~~ [FL-3686] Mifare Classic fixes Nov 20, 2023

Astrrra added 2 commits November 21, 2023 00:52

Fix the AC issues

1e7ba4d

CRC errors don't really affect emulation, checking for them isn't wor…

68c1067

…th it

Astrrra marked this pull request as ready for review November 21, 2023 10:18

Astrrra requested review from skotopes, DrZlo13, hedger and gornekich as code owners November 21, 2023 10:18

Astrrra and others added 3 commits November 22, 2023 14:16

Make ATQA logic a bit easier to understand

f631a68

mf classic: change log level

c85a3dc

mf classic: fix log level

116735f

gornekich approved these changes Nov 22, 2023

View reviewed changes

lib/nfc/protocols/mf_classic/mf_classic.c Outdated Show resolved Hide resolved

gornekich added the NFC NFC-related label Nov 22, 2023

Merge branch 'dev' into astra/nfc-fixes

24b331b

skotopes approved these changes Nov 26, 2023

View reviewed changes

skotopes merged commit f9101d8 into dev Nov 26, 2023

skotopes deleted the astra/nfc-fixes branch November 26, 2023 08:20