Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[FL-3690] Libraries cleanup; u2f crypto rework to use mbedtls #3234

Merged
merged 28 commits into from
Dec 1, 2023
Merged

[FL-3690] Libraries cleanup; u2f crypto rework to use mbedtls #3234

merged 28 commits into from
Dec 1, 2023

Conversation

hedger
Copy link
Member

@hedger hedger commented Nov 21, 2023 •
edited by skotopes
Loading

What's new

  • furi: added FURI_PACKED, FURI_CHECK_RETURN macros
  • FL-3690 apps: u2f: reworked using mbedtls only for crypto
  • apps: u2f: removed private hmac-sha256 impl
  • libs: removed micro-ecc, qrcode, fnv1a-hash
  • libs: split libmisc into smaller libs
  • libs: optimized root SConscript for clarity
  • libs: mbedtls: updated to latest release
  • libs: mbedtls: now using customised configuration header
  • libs: toolbox: removed private sha256 & md5 implementations, switched to mbedtls
  • apps: examples: example_plugins_advanced: now showcases fal_embedded manifest option
  • apps: include cleanup
  • fbt: fixed format_py & lint_py command lines being too long for Windows

Verification

  • build firmware, test u2f to work with previously generated keys

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 21, 2023 •
edited
Loading

Compiled f7 firmware for commit a878b900:

@github-actions GitHub Actions
Copy link

PVS-Studio report for commit 5c29a3c4:

@hedger hedger added Build System & Scripts fbt, scripts and toolchain-related Applications Non-core applications Core+Services HAL, furi & core system services labels Nov 24, 2023
@hedger hedger changed the title Hedger/libcleanup Library cleanup; u2f crypto rework to use mbedtls Nov 24, 2023
@hedger hedger changed the title Library cleanup; u2f crypto rework to use mbedtls Libraries cleanup; u2f crypto rework to use mbedtls Nov 24, 2023
@hedger hedger marked this pull request as ready for review November 24, 2023 17:39
@hedger hedger changed the title Libraries cleanup; u2f crypto rework to use mbedtls [FL-3690] Libraries cleanup; u2f crypto rework to use mbedtls Nov 24, 2023
@skotopes skotopes merged commit 890c9e8 into dev Dec 1, 2023
@skotopes skotopes deleted the hedger/libcleanup branch December 1, 2023 09:16
@JarvisCraft JarvisCraft mentioned this pull request Dec 24, 2023
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@Skorpionm Skorpionm Awaiting requested review from Skorpionm Skorpionm is a code owner

@gornekich gornekich Awaiting requested review from gornekich gornekich is a code owner

@Astrrra Astrrra Awaiting requested review from Astrrra Astrrra is a code owner

@nminaylov nminaylov Awaiting requested review from nminaylov nminaylov is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

Assignees
No one assigned
Labels
Applications Non-core applications Build System & Scripts fbt, scripts and toolchain-related Core+Services HAL, furi & core system services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hedger @skotopes