Add NDEF plugin #3923
Add NDEF plugin #3923
Conversation
bettse
requested review from
skotopes,
DrZlo13,
hedger,
gsurkov,
gornekich and
Astrrra
as code owners
There was a problem hiding this comment.
Tested this PR, works fine with simple NDEF blocks, but doesn't work with SmartPoster ndefs, (it's where type == 'Sp').
I tried to add SmartPoster support, you can check my patch
sp_ndef.patch
It works fine, but needs to be tested, because I didn't have enough time to test, so please try it
| return; | ||
| } | ||
| switch(tnf) { | ||
| case 0x01: // NFC Forum well-known type [NFC RTD] |
There was a problem hiding this comment.
It would be better to replace all these numbers with appropriate defines and remove comments at all.
| // Flags and TNF | ||
| uint8_t flags_tnf = *cur++; | ||
| // Message Begin should only be set on first record | ||
| if(record_num++ && flags_tnf & (1 << 7)) break; |
There was a problem hiding this comment.
Can we simplify this logic with the help of bitfield struct?
| // Parse as TLV (see docs above) | ||
| while(cur < end) { | ||
| switch(*cur++) { | ||
| case 0x03: { // NDEF message |
There was a problem hiding this comment.
It would be better to replace all these numbers with appropriate defines and remove comments at all.
| } | ||
|
|
||
| static void parse_ndef_uri(FuriString* str, const uint8_t* payload, uint32_t payload_len) { | ||
| // https://learn.adafruit.com/adafruit-pn532-rfid-nfc/ndef#uri-records-0x55-slash-u-607763 |
There was a problem hiding this comment.
Please, move all such comments out from the function bodies and place them in function description comments in front
|
@RebornedBrain This is bring brought over as-is from a customer firmware fork (not my original code), so I'd prefer not to make any changes except those the flipper devs feel are required. I've been in conversation with the original dev about further improvements (type 4 support) once it has been merged, and these other ideas would be welcome as well. |
What's new
Verification
Photo of reading Minecraft Earth figure using build of this branch
Checklist (For Reviewer)