Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

NFC: H World Hotel Chain Room Key Parser #3946

Merged
merged 4 commits into from
Oct 14, 2024
Merged

NFC: H World Hotel Chain Room Key Parser #3946

merged 4 commits into from
Oct 14, 2024

Conversation

zinongli
Copy link
Contributor

@zinongli zinongli commented Oct 14, 2024 •
edited by skotopes
Loading

What's new

  • A parser plugin for reading room number and check-in & expiration dates from a room key.
  • H World operates around 10k hotels and 1m rooms, most of which in mainland China.
  • The two types of keys (standard and VIP) are in fact used interchangeably. Both encoperate static key sets.
  • The parser helps with reading by including the static keys. It also verifies against the static keys before attempting to parse in order to prevent false positives.

Verification

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@skotopes
Copy link
Member

@zinongli looks like we don't have keys for VIP card in the dictionary.

Opening card dump shows info, but reading emulated card goes through dictionary attack.

@skotopes skotopes merged commit fbc3b49 into flipperdevices:dev Oct 14, 2024
11 checks passed
@zinongli
Copy link
Contributor Author

@skotopes do you mind reopen this so I can add those three keys? I can make a separate PR but this might be more effcient.

@skotopes
Copy link
Member

skotopes commented Oct 14, 2024 •
edited
Loading

@zinongli its already merged ) New PR please

@zinongli zinongli mentioned this pull request Oct 14, 2024
Merged
3 tasks
@zinongli
Copy link
Contributor Author

Sure thing, PR is up

RogueMaster pushed a commit to RogueMaster/flipperzero-firmware-wPlugins that referenced this pull request Oct 15, 2024
@zinongli @RogueMaster
NFC: H World Hotel Chain Room Key Parser (flipperdevices#3946)
2128dc5 
* quick and easy implementation
* delete debug artifacts
* log level correction (warning -> info)
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

@gornekich gornekich Awaiting requested review from gornekich gornekich is a code owner

@Astrrra Astrrra Awaiting requested review from Astrrra Astrrra is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zinongli @skotopes