Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[BadUSB] Improve ChromeOS and GNOME demo scripts #3948

Merged
merged 3 commits into from
Oct 15, 2024
Merged

[BadUSB] Improve ChromeOS and GNOME demo scripts #3948

merged 3 commits into from
Oct 15, 2024

Conversation

kowalski7cc
Copy link
Contributor

@kowalski7cc kowalski7cc commented Oct 14, 2024 •
edited by skotopes
Loading

What's new

  • GNOME demo: Support most terminals and not rely only on gnome-terminal, and force sh shell when not using Bash as default
  • ChromeOS demo: Minor improvements, such as exit overview before opening a tab, select omnibox and add a page title

Verification

  • Start the BadUSB script on the selected system

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@kowalski7cc
[BadUSB] Gnome Demo: Support most terminals and force sh shell when n…
d1bfa57 
…ot using Bash as default

Signed-off-by: Kowalski Dragon (kowalski7cc) <5065094+kowalski7cc@users.noreply.github.com>
@kowalski7cc
[BadUSB] ChromeOS Demo: Minor improvements, such as exit overview, se…
57dd6ef 
…lect omnibox and add a page title

Signed-off-by: Kowalski Dragon (kowalski7cc) <5065094+kowalski7cc@users.noreply.github.com>
@skotopes skotopes merged commit c917135 into flipperdevices:dev Oct 15, 2024
11 checks passed
RogueMaster pushed a commit to RogueMaster/flipperzero-firmware-wPlugins that referenced this pull request Oct 16, 2024
@kowalski7cc @skotopes @RogueMaster
[BadUSB] Improve ChromeOS and GNOME demo scripts (flipperdevices#3948)
ddd63b0 
* [BadUSB] Gnome Demo: Support most terminals and force sh shell when not using Bash as default
* [BadUSB] ChromeOS Demo: Minor improvements, such as exit overview, select omnibox and add a page title

Signed-off-by: Kowalski Dragon (kowalski7cc) <5065094+kowalski7cc@users.noreply.github.com>
Co-authored-by: Kowalski Dragon (kowalski7cc) <5065094+kowalski7cc@users.noreply.github.com>
Co-authored-by: あく <alleteam@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

@nminaylov nminaylov Awaiting requested review from nminaylov nminaylov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kowalski7cc @skotopes