nfc: add Caltrain zones to Clipper transit parser #3969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomholford
changed the title
tomholford
force-pushed
the
th/add-clipper-caltrain-zones
branch
from
05465af to
5b922c2
Compare
tomholford
requested review from
skotopes,
DrZlo13,
hedger,
gsurkov,
gornekich and
Astrrra
as code owners
|
LGTM. I have a few Caltrain rides on my Clipper card and the zones look correct to me. |
Thank you @ted-logan for testing! And for your work on #3937 |
tomholford
changed the title
skotopes
approved these changes
Oct 31, 2024
|
😆 @skotopes ありがとうございました |
|
どういたしまして（＾＿＾） |
RogueMaster
pushed a commit
to RogueMaster/flipperzero-firmware-wPlugins
that referenced
this pull request
Nov 2, 2024
Co-authored-by: tomholford <tomholford@users.noreply.github.com> Co-authored-by: あく <alleteam@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new
Inspired by #3937, this PR adds labels for Caltrain zones to the built-in Clipper NFC capture parser.
Before
After
Context
I scanned a Clipper transit card with my Flipper and found a Caltrain record. This was for a ride I took from a station in Zone 2 to a station in Zone 4. Note the 'Unknown' ON / OFF values in the Before screenshot, and the correct labels in the After image (tested on my device).
Note that unlike BART, instead of persisting individual station IDs, it appears the Caltrain tag devices save the Zone ID, since the delta in # of zones traveled is what is used to calculate the fare.
For reference, here is a map of the Zones:
Caltrain Zone Map
And here is more information on the zone system:
https://www.caltrain.com/stations-zones
Verification
edit: verified by @ted-logan in this comment below: #3969 (comment)
I have tested this on my device, and used this change to generate the After image.
This can also be verified by anyone with a Flipper and a Clipper. Perhaps @ted-logan, since he opened the previous Clipper PR that inspired this one.
Scan the Clipper card with the NFC reader and check a Caltrain ride to verify the zone labels.
Checklist (For Reviewer)