Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

u2f: Fix leaking message digest contexts #4052

Merged
merged 3 commits into from
Jan 10, 2025
Merged

u2f: Fix leaking message digest contexts #4052

merged 3 commits into from
Jan 10, 2025

Conversation

GMMan
Copy link
Contributor

@GMMan GMMan commented Dec 31, 2024 •
edited by skotopes
Loading

What's new

  • Frees two mbedtls MD contexts that have not been freed after use

Verification

  • This may or may not get picked up in static analysis

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@skotopes skotopes merged commit 5efdab8 into flipperdevices:dev Jan 10, 2025
11 checks passed
Akiva-Cohen pushed a commit to Akiva-Cohen/flipperzero-firmware that referenced this pull request Jan 14, 2025
@GMMan @skotopes @Akiva-Cohen
u2f: Fix leaking message digest contexts (flipperdevices#4052)
7db3550 
* u2f: Fix leaking message digest contexts
* Github: fix doxygen version to 1.12

Co-authored-by: あく <alleteam@gmail.com>
Akiva-Cohen pushed a commit to Akiva-Cohen/flipperzero-firmware that referenced this pull request Jan 14, 2025
@GMMan @skotopes @Akiva-Cohen
u2f: Fix leaking message digest contexts (flipperdevices#4052)
9e9dd67 
* u2f: Fix leaking message digest contexts
* Github: fix doxygen version to 1.12

Co-authored-by: あく <alleteam@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

@nminaylov nminaylov Awaiting requested review from nminaylov nminaylov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GMMan @skotopes