Allow access to internal C FuriString #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed as there are certain APIs that are not accessible through the Rust bindings (e.g. `furi_string_printf`). This function is safe because just holding a pointer is OK as you can't use it to perform any unsafe operations without making an unsafe action such as dereferencing or passing to a C function.
This allows consuming and taking ownership of the internal `sys::FuriString` pointer for the purposes of C APIs that take ownership of a string.
JarvisCraft
approved these changes
Jan 23, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required as there are certain APIs that are not accessible through safe Rust bindings (e.g.
furi_string_printfis variadic).Both functions are safe because you can't use it to perform any unsafe operations without making an unsafe action such as dereferencing or passing to a C function.