Skip to content
This repository has been archived by the owner on Dec 5, 2024. It is now read-only.

fix: flow type fixes for popper-core 2.3.3 #355

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

FezVrasta
Copy link
Member

This PR is based on #352

I have a problem with the following error though πŸ€”

Error β”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆβ”ˆ src/usePopper.js:95:37

Cannot call React.useMemo with function bound to create because string [1] is incompatible with string literal
updateState [2] in property name of array element of property modifiers of the return value.

 [2] 27β”‚ type UpdateStateModifier = Modifier<'updateState', {||}>;
       :
 [1] 90β”‚         { name: 'applyStyles', enabled: false },
     91β”‚       ],
     92β”‚     };
     93β”‚
     94β”‚     if (isEqual(prevOptions.current, newOptions)) {
     95β”‚       return prevOptions.current || newOptions;
     96β”‚     } else {
     97β”‚       prevOptions.current = newOptions;
     98β”‚       return newOptions;

@FezVrasta FezVrasta force-pushed the fix/flow-type-fixes branch 3 times, most recently from 6483505 to e485a05 Compare April 21, 2020 14:50
@FezVrasta FezVrasta force-pushed the fix/flow-type-fixes branch from e485a05 to 2b4200c Compare April 21, 2020 14:53
@FezVrasta FezVrasta force-pushed the fix/flow-type-fixes branch from 2b4200c to be38e84 Compare April 21, 2020 14:54
@rollingversions
Copy link

rollingversions bot commented Apr 28, 2020

There is no change log for this pull request yet.

Create a changelog

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants