Add support for storage buffers in C3 generator + small fixes #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radekm
changed the title
|
@floooh I believe this is ready to be merged. |
|
Ooops, sorry for the delay. I'm currently catching up on PRs and will look into this next. |
radekm
force-pushed
the
c3-lang-support-storage-buffers
branch
from
372bcb0 to
4132803
Compare
floooh
reviewed
Feb 10, 2025
Comment on lines
+63
to
+65
| case Type::Float4: l("float[4][{}] {};\n", uniform.array_count, uniform.name); break; | ||
| case Type::Int4: l("int[4][{}] {};\n", uniform.array_count, uniform.name); break; | ||
| case Type::Mat4x4: l("float[16][{}] {};\n", uniform.array_count, uniform.name); break; |
There was a problem hiding this comment.
Sneaky... so apparently C3 has inverted dimensions (inner-most to outer-most) for declaring the array, but then C-style index order for array item access? Weird but ok ;)
https://c3-lang.org/language-common/arrays/#fixed-size-multi-dimensional-arrays
|
Ok merged. Now on to floooh/sokol#1148 :) |
|
Binaries in https://github.com/floooh/sokol-tools-bin have been updated too. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.