Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Extract common code from request function #23

Merged
merged 3 commits into from
Sep 5, 2024

Conversation

LukasPietzschmann
Copy link
Collaborator

No description provided.

@LukasPietzschmann LukasPietzschmann added the enhancement New feature or request label Sep 2, 2024
@LukasPietzschmann LukasPietzschmann self-assigned this Sep 2, 2024
@LukasPietzschmann
Copy link
Collaborator Author

I think I could also implement a create_request_function function, which can return (or generate) a function like request_slice. But I'm struggling with R at the moment, so this is not yet ready xD

@EagleoutIce
Copy link
Member

i think there is no need to overengineer this right now

@LukasPietzschmann LukasPietzschmann linked an issue Sep 2, 2024 that may be closed by this pull request
@LukasPietzschmann
Copy link
Collaborator Author

But it would be cool, wouldn't it. Let me try it later today in my free time. And if I can't get it to work today, we can still scrap the idea. Deal? :D

@EagleoutIce
Copy link
Member

👍 so simply (re-)ping me when you're done with whatever decision you come to :)

@LukasPietzschmann
Copy link
Collaborator Author

@EagleoutIce 🛎️ (re)ping :)

I didn't manage to get it to work. So feel free to merge what I got so far.

@EagleoutIce EagleoutIce marked this pull request as ready for review September 4, 2024 12:37
R/utils.R Show resolved Hide resolved
@EagleoutIce EagleoutIce merged commit d396711 into main Sep 5, 2024
12 checks passed
@EagleoutIce EagleoutIce deleted the 20-add-function-for-lineage-request branch September 5, 2024 07:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract common code from request function
2 participants