Adding YAML examples to developers wasm filter plugin docs. Fixes #1768. #1769
+59
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uent#1768. Signed-off-by: Eric D. Schabell <eric@schabell.org>
| @@ -110,13 +134,16 @@ Once built, a Wasm program will be available. Then you can execute that built pr | |||
| Match dummy.* | |||
| WASM_Path /path/to/built_filter.wasm | |||
| Function_Name super_awesome_filter | |||
| accessible_paths .,/path/to/fluent-bit | |||
| accessible_paths /path/to/fluent-bit | |||
There was a problem hiding this comment.
Just checking this change, is the original one a comma separated list with . allowing you to be path agnostic @cosmo0920 or is it just a typo?
There was a problem hiding this comment.
It isn't typo. Just including for the current working directory.
However, this should be removed if we pursue the rigid permission list approach.
Sometimes, I put Wasm programs into /path/to/fluent-bit/build directory and run fluent-bit in /path/to/fluent-bit/build directory. So, if we remove the magic . period symbol, we need to write the actual path of the place that contains the actual Wasm programs.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding YAML examples to developers wasm filter plugin docs. Fixes #1768.