Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: remove redundant data from stored macros #1356

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

matmen
Copy link
Member

@matmen matmen commented Feb 11, 2024

Follow-up on #1355

Signed-off-by: Mathis Mensing <github@matmen.dev>
@matmen matmen added the Code - Optimizations Everything that relates to code optimizations! label Feb 11, 2024
@matmen matmen added this to the 1.28.1 milestone Feb 11, 2024
Copy link
Member

@pedrolamas pedrolamas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to also include the order field, without that it will not store the order changes!

src/store/macros/getters.ts Outdated Show resolved Hide resolved
Co-authored-by: Pedro Lamas <pedrolamas@gmail.com>
Signed-off-by: Mathis Mensing <github@matmen.dev>
@matmen matmen merged commit c105dc7 into fluidd-core:develop Feb 12, 2024
4 checks passed
@matmen matmen deleted the fix/redundant-macro-data branch February 12, 2024 19:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Code - Optimizations Everything that relates to code optimizations!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants