Stager scene for Property Editor #8573
Conversation
| final GlobalKey<FormState> formKey; | ||
|
|
||
| // We assume a DTD is available on 8500. There's a VS Code task that | ||
| // launches this as part of the standalone_ui/editor_sidebar config. |
There was a problem hiding this comment.
nit: I guess this should say standalone_ui/property_editor_sidebar config?
Is the intention that the mock editor will have the ability to send fake editor events, or that you'd just always use this with a real IDE and connect to DTD that it spawned (if the latter, the DTD being spawned on 8500 is probably pointless?).
There was a problem hiding this comment.
I was thinking it might be useful to send fake editor events eventually (to simulate clicking on a widget) but currently I'm just using a real IDE.
packages/devtools_app/lib/src/standalone_ui/vs_code/property_editor_panel.dart
Show resolved
Hide resolved
packages/devtools_app/lib/src/standalone_ui/vs_code/property_editor_panel.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/lib/src/standalone_ui/vs_code/property_editor_panel.dart
Show resolved
Hide resolved
packages/devtools_app/test/test_infra/scenes/standalone_ui/property_editor_sidebar.dart
Outdated
Show resolved
Hide resolved
devtools_options.yaml
Outdated
There was a problem hiding this comment.
Hmm this file keeps being generated (I'm not sure what triggers it). I've been manually deleting it but it looks like I missed it in this latest commit. @kenzieschmoll this is related to DevTools extensions, right? I can delete it for now, but I want to figure out what is creating it.
There was a problem hiding this comment.
Yeah I would recommend deleting it for now. I think this might be related to switching to workspaces. Feel free to file a bug and I will take a look.
There was a problem hiding this comment.
Sounds good, removed and opened #8589
| ), | ||
| return Align( | ||
| alignment: Alignment.topCenter, | ||
| child: Expanded( |
There was a problem hiding this comment.
Expanded should only be used as a direct child of a flex widget like Column or Row
There was a problem hiding this comment.
Oops thanks, removed the expanded!
Work towards #1948
This PR:
Follow-up: