[Property Editor] Refactor Property Editor for better code sharing #8797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...es/devtools_app/lib/src/standalone_ui/ide_shared/property_editor/property_editor_inputs.dart
Show resolved
Hide resolved
...es/devtools_app/lib/src/standalone_ui/ide_shared/property_editor/property_editor_inputs.dart
Outdated
Show resolved
Hide resolved
...es/devtools_app/lib/src/standalone_ui/ide_shared/property_editor/property_editor_inputs.dart
Outdated
Show resolved
Hide resolved
...es/devtools_app/lib/src/standalone_ui/ide_shared/property_editor/property_editor_inputs.dart
Outdated
Show resolved
Hide resolved
...ages/devtools_app/lib/src/standalone_ui/ide_shared/property_editor/property_editor_view.dart
Outdated
Show resolved
Hide resolved
kenzieschmoll
approved these changes
Jan 23, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #1948
Refactors the Property Editor code to include:
property_editor_types: classes extendingEditableArgumentwith mixins to provide functionality specific for the property typeproperty_editor_inputs: series of input widgets specialized for each property typeThis moves all the special-casing logic for types out of the
property_editor_view