-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Reland "[Fuchsia] only download fuchsia deps when necessary (#51439)" #51508
Closed
zijiehe-google-com
wants to merge
11
commits into
main
from
revert-51500-revert_9162c8309e247be465bb4fa7173f704c2053b9b3
Closed
Reland "[Fuchsia] only download fuchsia deps when necessary (#51439)" #51508
zijiehe-google-com
wants to merge
11
commits into
main
from
revert-51500-revert_9162c8309e247be465bb4fa7173f704c2053b9b3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A little bit struggling to demonstrate the importance of this change; keep it as a draft for now. The only benefit of this change is to avoid downloading images in two of eight drone builders which was unfortunately caused by a typo in the original change. |
(triage): reached out to author for more feedback |
Thank you for reaching out. As mentioned in #51508 (comment), this change isn't important enough to merge. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #51500 and relands #51439 with the default
download_fuchsia_deps
unchanged and enabled viahost_os == "linux"
.Something not mentioned in the previous change description, since the engine_v2 recipe now supports
gclient_variables
forwarding, I moved the duplicateddownload_android_deps: False
into the.ci.yaml
, i.e. the root builder from the droneci/builders/linux_fuchsia.json
file.Original change description:
This is a quick follow up of #51072 to only download fuchsia deps (via download_fuchsia_deps gclient arg) when necessary. Considering the pr/51072 is very huge, keeping these condition changes in a separate change would be cleaner.
The wiki has been updated already since setting the download_fuchsia_deps gclient arg explicitly won't break the existing workflow. I also mentioned in the wiki that building and running fuchsia needed a linux box (an explicit assertion in the with_envs.py).
Bug: http://b/40935282