-
Notifications
You must be signed in to change notification settings - Fork 6k
Move testing/litetest to pub workspaces. #54082
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
auto label is removed for flutter/engine/54082, due to - The status or check suite Linux linux_fuchsia has failed. Please fix the issues identified (or deflake) before re-applying this label. |
# In all other cases we default to "2.8" | ||
env_sdk = parsed.get('environment', {}).get('sdk', 'any') | ||
match = re.search(r'^(>=)?((0|[1-9]\d*)\.(0|[1-9]\d*))', env_sdk) | ||
match = re.search(r'^(>=|^)?((0|[1-9]\d*)\.(0|[1-9]\d*))', env_sdk) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The caret character will need to be escaped: (>=|\^)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
auto label is removed for flutter/engine/54082, due to - The status or check suite Linux local_engine_builds has failed. Please fix the issues identified (or deflake) before re-applying this label. |
…152278) flutter/engine@4b95209...eb8fac2 2024-07-24 chris@bracken.jp [iOS] Build universal gen_snapshots for iOS (flutter/engine#54009) 2024-07-24 matanlurey@users.noreply.github.com Move testing/litetest to pub workspaces. (flutter/engine#54082) 2024-07-24 skia-flutter-autoroll@skia.org Roll Skia from 1561e2127c6f to 54d1434637a1 (2 revisions) (flutter/engine#54087) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#152278) flutter/engine@4b95209...eb8fac2 2024-07-24 chris@bracken.jp [iOS] Build universal gen_snapshots for iOS (flutter/engine#54009) 2024-07-24 matanlurey@users.noreply.github.com Move testing/litetest to pub workspaces. (flutter/engine#54082) 2024-07-24 skia-flutter-autoroll@skia.org Roll Skia from 1561e2127c6f to 54d1434637a1 (2 revisions) (flutter/engine#54087) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#152278) flutter/engine@4b95209...eb8fac2 2024-07-24 chris@bracken.jp [iOS] Build universal gen_snapshots for iOS (flutter/engine#54009) 2024-07-24 matanlurey@users.noreply.github.com Move testing/litetest to pub workspaces. (flutter/engine#54082) 2024-07-24 skia-flutter-autoroll@skia.org Roll Skia from 1561e2127c6f to 54d1434637a1 (2 revisions) (flutter/engine#54087) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
More incremental version of #53997.