Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Migrate or remove all API usages that will be removed with time #7718

Open
jwren opened this issue Oct 16, 2024 · 3 comments
Open

Migrate or remove all API usages that will be removed with time #7718

jwren opened this issue Oct 16, 2024 · 3 comments
Assignees
@jwren
Labels
bug d: intellij P1
Milestone
M86

Comments

@jwren
Copy link
Member

jwren commented Oct 16, 2024

Many of the errors reported in the JetBrains marketplace, https://plugins.jetbrains.com/plugin/9212-flutter/edit/versions/stable/615584, are for deprecated issues which will be removed, these usages in the Flutter plugin need to be migrated or removed.
@jwren jwren added this to the M83 milestone Oct 16, 2024
@jwren jwren self-assigned this Oct 16, 2024
@jwren jwren mentioned this issue Oct 16, 2024
Merged
jwren added a commit to jwren/flutter-intellij that referenced this issue Oct 16, 2024
@jwren
Migrate off of ServiceManager.getServiceIfCreated API usage
2b786ae 
https://github.com/JetBrains/intellij-community/blob/337bcc327a5d34720e134e312768de414c5572b0/platform/core-api/src/com/intellij/openapi/components/ServiceManager.java#L35

https://github.com/JetBrains/intellij-community/blob/d587049edb9cc85f67d4e070584ad79f68befc2e/platform/execution/src/com/intellij/execution/ExecutionManager.kt#L40

flutter#7718
@jwren jwren mentioned this issue Oct 16, 2024
Merged
jwren added a commit to jwren/flutter-intellij that referenced this issue Oct 16, 2024
@jwren
Migrate off of ServiceManager.getServiceIfCreated API usage
9957171 
https://github.com/JetBrains/intellij-community/blob/337bcc327a5d34720e134e312768de414c5572b0/platform/core-api/src/com/intellij/openapi/components/ServiceManager.java#L35

https://github.com/JetBrains/intellij-community/blob/d587049edb9cc85f67d4e070584ad79f68befc2e/platform/execution/src/com/intellij/execution/ExecutionManager.kt#L40

flutter#7718
jwren added a commit that referenced this issue Oct 16, 2024
@jwren
Migrate off of ServiceManager.getServiceIfCreated API usage (#7719)
0443a40 
https://github.com/JetBrains/intellij-community/blob/337bcc327a5d34720e134e312768de414c5572b0/platform/core-api/src/com/intellij/openapi/components/ServiceManager.java#L35


https://github.com/JetBrains/intellij-community/blob/d587049edb9cc85f67d4e070584ad79f68befc2e/platform/execution/src/com/intellij/execution/ExecutionManager.kt#L40

This is progress towards resolving
#7718
@jwren
Copy link
Member Author

jwren commented Nov 15, 2024

The pre-requisite for this was to migrate to Gradle IntelliJ platform 2.1.x to have the updated verifier which is done, this work will not be finished for this upcoming Milestone, bumping to the next one.

@jwren jwren modified the milestones: M83, M84 Nov 15, 2024
jwren added a commit to jwren/flutter-intellij that referenced this issue Dec 4, 2024
@jwren
Migrate off of Extensions.findExtension(..) usages
dd3ab4d 
This is progress on flutter#7718
jwren added a commit to jwren/flutter-intellij that referenced this issue Dec 4, 2024
@jwren
Migrate off of FileChooserUtil.setLastOpenedFile(..)
1f74995 
https://github.com/JetBrains/intellij-community/blob/768c7392257e8fbedcc1aa4c738fa523b89fa0e6/platform/platform-impl/src/com/intellij/openapi/fileChooser/impl/FileChooserUtil.java#L45

This is progress on flutter#7718
This was referenced Dec 4, 2024
Merged
Merged
jwren added a commit to jwren/flutter-intellij that referenced this issue Dec 4, 2024
@jwren
Migrate off of ServiceManager.getService(..)
9f4929a 
https://github.com/JetBrains/intellij-community/blob/768c7392257e8fbedcc1aa4c738fa523b89fa0e6/platform/core-api/src/com/intellij/openapi/components/ServiceManager.java#L19

This is progress on flutter#7718
@jwren jwren mentioned this issue Dec 4, 2024
Merged
jwren added a commit that referenced this issue Dec 4, 2024
@jwren
Migrate off of Extensions.findExtension(..) usages (#7846)
46b78f8 
This is progress on
#7718
jwren added a commit that referenced this issue Dec 4, 2024
@jwren
Migrate off of ServiceManager.getService(..) (#7847)
9e6ca34 
https://github.com/JetBrains/intellij-community/blob/768c7392257e8fbedcc1aa4c738fa523b89fa0e6/platform/core-api/src/com/intellij/openapi/components/ServiceManager.java#L19

This is progress on
#7718

The removal of the method in
flutter-idea/src/io/flutter/module/settings/SettingsHelpForm.java is due
to the method being unused
jwren added a commit that referenced this issue Dec 4, 2024
@jwren
Migrate off of FileChooserUtil.setLastOpenedFile(..) (#7845)
403f359 
https://github.com/JetBrains/intellij-community/blob/768c7392257e8fbedcc1aa4c738fa523b89fa0e6/platform/platform-impl/src/com/intellij/openapi/fileChooser/impl/FileChooserUtil.java#L45

This is progress on
#7718
jwren added a commit to jwren/flutter-intellij that referenced this issue Dec 17, 2024
@jwren
Migrate from deprecated method: JsonParser().parse() to JsonParser.pa…
6afe1e9 
…rseString(..)

flutter#7718
@jwren jwren mentioned this issue Dec 17, 2024
Merged
jwren added a commit to jwren/flutter-intellij that referenced this issue Dec 17, 2024
@jwren
Migrate from deprecated method: ProjectTopics.X to ModuleListener.X
6d9da27 
flutter#7718
@jwren jwren mentioned this issue Dec 17, 2024
Merged
jwren added a commit that referenced this issue Dec 17, 2024
@jwren
Migrate from deprecated method: JsonParser().parse() to JsonParser.pa…
1bc5151 
…rseString(..) (#7868)

#7718
jwren added a commit that referenced this issue Dec 17, 2024
@jwren
Migrate from deprecated method: ProjectTopics.X to ModuleListener.X (#…
c436bda 
…7869)

#7718


https://github.com/JetBrains/intellij-community/blob/ab4c7fdf3cc2887d44d081681ec642843adfff6d/platform/projectModel-api/src/com/intellij/ProjectTopics.java#L12
@jwren jwren mentioned this issue Jan 8, 2025
Merged
jwren added a commit that referenced this issue Jan 8, 2025
@jwren
Migrate off of Extensions.getExtensions() usages (#7884)
370efa4 
This is progress towards
#7718
@jwren jwren modified the milestones: M84, M85 Feb 10, 2025
This was referenced Apr 8, 2025
Merged
Merged
Merged
Open
@jwren jwren modified the milestones: M85, M86 Apr 9, 2025
jwren pushed a commit that referenced this issue Apr 9, 2025
@pq
[CQ] migrate from slated-for-removal RunLineMarkerContributor.Info …
20e2330 
…APIs (#8014)

Migrate to supported `RunLineMarkerContributor.Info` constructor uses.

![image](https://github.com/user-attachments/assets/7d802b0e-8ebd-4e80-876d-6040d67d1c56)

See: #7718.
jwren pushed a commit that referenced this issue Apr 9, 2025
@pq
[CQ] AddToAppUtils: fix deprecated API use and unchecked calls (#8012)
2c53a81 
Migrate to future-safe `modulesAdded` API and fix unchecked calls.

(Removing another bit of noise from the run console.)


![image](https://github.com/user-attachments/assets/820a76c6-a99a-4251-9bab-f684fff60754)

See: #7718.
jwren pushed a commit that referenced this issue Apr 9, 2025
@pq
[CQ]: migrate to supported Notification API (#8013)
4a98ce6 
Migrate away from slated-for-removal `Notification` API.


![image](https://github.com/user-attachments/assets/fe309662-b13d-4c71-98ed-b6bfdf6326e1)


See:
https://github.com/JetBrains/intellij-community/blob/b41a4084da5521effedd334e28896fd9d07410da/platform/ide-core/src/com/intellij/notification/Notification.java#L87

See: #7718.
@jwren
Copy link
Member Author

jwren commented Apr 10, 2025

Some additional work in #8018

@jwren
Copy link
Member Author

jwren commented Apr 11, 2025

Latest report from the marketplace continues to show progress and opportunity: https://plugins.jetbrains.com/plugin/9212-flutter/edit/versions/stable/712464. Also related, the verifier is currently not working see #8034 for status.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@jwren jwren

Labels
bug d: intellij P1
Projects
None yet
Milestone
M86
Development

No branches or pull requests
1 participant
@jwren