Skip to content

Start to remove the now deprecated Inspector view, Dart DevTools now supports all of these features #7706

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Oct 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions flutter-idea/src/io/flutter/inspector/EvalOnDartLibrary.java
Original file line number Diff line number Diff line change
Expand Up @@ -147,10 +147,6 @@ public String getIsolateId() {
return isolateId;
}

CompletableFuture<LibraryRef> getLibraryRef() {
return libraryRef;
}

public void dispose() {
subscription.dispose();
// TODO(jacobr): complete all pending futures as cancelled?
Expand Down Expand Up @@ -267,18 +263,6 @@ public CompletableFuture<Func> getFunc(FuncRef instance, InspectorService.Object
return getObjectHelper(instance, isAlive);
}

public CompletableFuture<Instance> getInstance(CompletableFuture<InstanceRef> instanceFuture, InspectorService.ObjectGroup isAlive) {
return instanceFuture.thenComposeAsync((instance) -> getInstance(instance, isAlive));
}

private JsonObject convertMapToJsonObject(Map<String, String> map) {
final JsonObject obj = new JsonObject();
for (String key : map.keySet()) {
obj.addProperty(key, map.get(key));
}
return obj;
}

private void initialize(String isolateId) {
this.isolateId = isolateId;

Expand Down
21 changes: 0 additions & 21 deletions flutter-idea/src/io/flutter/inspector/InspectorService.java
Original file line number Diff line number Diff line change
Expand Up @@ -453,23 +453,6 @@ private void onVmServiceReceived(String streamId, Event event) {
}
}

/**
* If the widget tree is not ready, the application should wait for the next
* Flutter.Frame event before attempting to display the widget tree. If the
* application is ready, the next Flutter.Frame event may never come as no
* new frames will be triggered to draw unless something changes in the UI.
*/
public CompletableFuture<Boolean> isWidgetTreeReady() {
if (useServiceExtensionApi()) {
return invokeServiceExtensionNoGroup("isWidgetTreeReady", new JsonObject())
.thenApplyAsync(JsonElement::getAsBoolean);
}
else {
return invokeEvalNoGroup("isWidgetTreeReady")
.thenApplyAsync((InstanceRef ref) -> "true".equals(ref.getValueAsString()));
}
}

CompletableFuture<JsonElement> invokeServiceExtensionNoGroup(String methodName, List<String> args) {
final JsonObject params = new JsonObject();
for (int i = 0; i < args.size(); ++i) {
Expand All @@ -482,10 +465,6 @@ private CompletableFuture<Void> addPubRootDirectories(List<String> rootDirectori
return invokeServiceExtensionNoGroup("addPubRootDirectories", rootDirectories).thenApplyAsync((ignored) -> null);
}

CompletableFuture<InstanceRef> invokeEvalNoGroup(String methodName) {
return getInspectorLibrary().eval("WidgetInspectorService.instance." + methodName + "()", null, null);
}

CompletableFuture<JsonElement> invokeServiceExtensionNoGroup(String methodName, JsonObject params) {
return invokeServiceExtensionHelper(methodName, params);
}
Expand Down
129 changes: 0 additions & 129 deletions flutter-idea/src/io/flutter/inspector/InspectorTree.java

This file was deleted.

63 changes: 0 additions & 63 deletions flutter-idea/src/io/flutter/inspector/InspectorTreeActionBase.java

This file was deleted.

38 changes: 0 additions & 38 deletions flutter-idea/src/io/flutter/inspector/JumpToSourceAction.java

This file was deleted.

78 changes: 0 additions & 78 deletions flutter-idea/src/io/flutter/inspector/JumpToSourceActionBase.java

This file was deleted.

Loading
Loading