Skip to content

Expand deprecation policy to package:flutter_driver #139249

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
4 tasks done
Piinks opened this issue Nov 29, 2023 · 3 comments
Closed
4 tasks done

Expand deprecation policy to package:flutter_driver #139249

Piinks opened this issue Nov 29, 2023 · 3 comments
Assignees
Labels
c: API break Backwards-incompatible API changes c: tech-debt Technical debt, code quality, testing, etc. framework flutter/packages/flutter repository. See also f: labels. P2 Important issues not at the top of the work list team-framework Owned by Framework team triaged-framework Triaged by Framework team

Comments

@Piinks
Copy link
Contributor

Piinks commented Nov 29, 2023

This is the tracking issue for the proposal to expand the deprecation policy to package:flutter_driver

Now that flutter and flutter_test have been successfully adopted, we are looking to expand the deprecation policy to other packages, with flutter_driver being next.

This will involve:

  • adding dart fix support to flutter_driver
  • advance communication to users and a feedback period
  • deprecation notice formatting enforcement
  • updating the deprecation policy on the wiki and website to list enforced packages

If we were to do this after the next release (not the current round in #139243 but the next round), these would be up for removal:

class / method property deprecated in
CommandHandlerFactory _waitUntilNoTransientCallbacks 1.9
CommandHandlerFactory _waitUntilNoPendingFrame 1.9
CommandHandlerFactory _waitUntilFirstFrameRasterized 1.9
FlutterDriver enableAccessibility 2.3
TimelineSummary writeSummaryToFile 2.1
@Piinks Piinks added framework flutter/packages/flutter repository. See also f: labels. c: API break Backwards-incompatible API changes P2 Important issues not at the top of the work list c: tech-debt Technical debt, code quality, testing, etc. team-framework Owned by Framework team triaged-framework Triaged by Framework team labels Nov 29, 2023
@Piinks Piinks self-assigned this Nov 29, 2023
@ImadBouirmane
Copy link

Thanks @Piinks
It's really helpful 👌🏻

auto-submit bot pushed a commit that referenced this issue Jan 11, 2024
Part of #139249

This adds dart fix support plus fixes for APIs that are currently deprecated in the flutter_driver package.
@Piinks
Copy link
Contributor Author

Piinks commented Feb 22, 2024

Closing as we are preparing to implement in #143956

@Piinks Piinks closed this as completed Feb 22, 2024
Copy link

github-actions bot commented Mar 7, 2024

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 7, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
c: API break Backwards-incompatible API changes c: tech-debt Technical debt, code quality, testing, etc. framework flutter/packages/flutter repository. See also f: labels. P2 Important issues not at the top of the work list team-framework Owned by Framework team triaged-framework Triaged by Framework team
Projects
None yet
Development

No branches or pull requests

2 participants