Upload generated frame-request-pending stats #135645

moffatman · 2023-09-28T04:03:49Z

These values are generated since #135279, but I didn't know to add the new keys to this list to get them to upload.

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
All existing and new tests are passing.

jonahwilliams

LGTM

auto-submit · 2023-09-28T04:22:45Z

auto label is removed for flutter/flutter/135645, due to - The status or check suite Mac framework_tests_misc has failed. Please fix the issues identified (or deflake) before re-applying this label.

The status or check suite Linux framework_tests_misc has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2023-09-28T05:42:19Z

auto label is removed for flutter/flutter/135645, due to - The status or check suite Mac web_tool_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

This reverts commit dd341d4.

Reverts #135645

…#135645)

Roll Flutter from ff4a0f6 to 57b5c3c (47 revisions) flutter/flutter@ff4a0f6...57b5c3c 2023-09-29 engine-flutter-autoroll@skia.org Roll Packages from c070b0a to d0e9a0e (5 revisions) (flutter/flutter#135753) 2023-09-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from db4d3b5b3f59 to c52251a8b2d0 (1 revision) (flutter/flutter#135748) 2023-09-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8b4e633c65eb to db4d3b5b3f59 (2 revisions) (flutter/flutter#135745) 2023-09-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 09130bf5be97 to 8b4e633c65eb (1 revision) (flutter/flutter#135744) 2023-09-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from ccb30585d3f3 to 09130bf5be97 (1 revision) (flutter/flutter#135741) 2023-09-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2052515c44f3 to ccb30585d3f3 (1 revision) (flutter/flutter#135737) 2023-09-29 godofredoc@google.com Update localizations. (flutter/flutter#135691) 2023-09-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 485543c6765a to 2052515c44f3 (4 revisions) (flutter/flutter#135732) 2023-09-29 54558023+keyonghan@users.noreply.github.com Add arch property for windows_arm64 platform (flutter/flutter#135725) 2023-09-29 jonahwilliams@google.com [flutter_tools] remove VmService screenshot for native devices. (flutter/flutter#135462) 2023-09-29 polinach@google.com Pin leak_tracker before publishing breaking change. (flutter/flutter#135720) 2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from cc7c3c1f0f41 to 485543c6765a (8 revisions) (flutter/flutter#135717) 2023-09-28 katelovett@google.com Remove assertions on getOffsetToReveal (flutter/flutter#135634) 2023-09-28 fluttergithubbot@gmail.com Marks Linux_android flutter_gallery__start_up_delayed to be unflaky (flutter/flutter#135565) 2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from dbb60932a6ab to cc7c3c1f0f41 (2 revisions) (flutter/flutter#135701) 2023-09-28 yjbanov@google.com [tool] fallback to sigkill when closing Chromium (flutter/flutter#135521) 2023-09-28 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#135455) 2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9789dbc2ec3f to dbb60932a6ab (2 revisions) (flutter/flutter#135694) 2023-09-28 leroux_bruno@yahoo.fr Fix TabBarView.viewportFraction change is ignored (flutter/flutter#135590) 2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from d9eaebd05851 to 9789dbc2ec3f (2 revisions) (flutter/flutter#135688) 2023-09-28 matheus@btor.com.br Added option to disable [NavigationDestination]s ([NavigationBar] destination widget) (flutter/flutter#132361) 2023-09-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Marks Windows module_custom_host_app_name_test to be unflaky" (flutter/flutter#135692) 2023-09-28 github@alexv525.com ð�� Add more fields to `RefreshProgressIndicator` (flutter/flutter#135207) 2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from 82b69dadc07a to d9eaebd05851 (1 revision) (flutter/flutter#135679) 2023-09-28 andrewrkolos@gmail.com Add API to read flavor from framework at run time (flutter/flutter#134179) 2023-09-28 fluttergithubbot@gmail.com Marks Windows module_custom_host_app_name_test to be unflaky (flutter/flutter#135567) 2023-09-28 tauu@h2overclock.de [web] fix: do not call onSubmitted of TextField when switching browser tabs on mobile web (flutter/flutter#134870) 2023-09-28 engine-flutter-autoroll@skia.org Roll Packages from 21c2ebb to c070b0a (3 revisions) (flutter/flutter#135676) 2023-09-28 tessertaha@gmail.com Fix `RangeSlider` throws an exception in a `ListView` (flutter/flutter#135667) 2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from d09c2dbe2292 to 82b69dadc07a (2 revisions) (flutter/flutter#135675) 2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from 495955a3b5de to d09c2dbe2292 (1 revision) (flutter/flutter#135669) 2023-09-28 zanderso@users.noreply.github.com Revert "Upload generated frame-request-pending stats" (flutter/flutter#135672) 2023-09-28 smartercallum@gmail.com Upload generated frame-request-pending stats (flutter/flutter#135645) 2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from 937bf0432214 to 495955a3b5de (1 revision) (flutter/flutter#135665) 2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from d2540d87fd96 to 937bf0432214 (1 revision) (flutter/flutter#135660) 2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from c47faed53afe to d2540d87fd96 (2 revisions) (flutter/flutter#135652) 2023-09-28 tessertaha@gmail.com Update `TextField.style` documentation for Material 3 (flutter/flutter#135556) 2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from 44aef2e61718 to c47faed53afe (1 revision) (flutter/flutter#135647) 2023-09-28 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from be32dcc9117a to 44aef2e61718 (4 revisions) (flutter/flutter#135646) 2023-09-28 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from f70f65f7a622 to be32dcc9117a (31 revisions) (flutter/flutter#135637) 2023-09-28 rmolivares@renzo-olivares.dev Implement SelectionArea single click/tap gestures (flutter/flutter#132682) 2023-09-27 katelovett@google.com Support ensureVisible/showOnScreen/showInViewport for 2D Scrolling (flutter/flutter#135182) 2023-09-27 caseycrogers@berkeley.edu made top level if checks gaurd clauses (flutter/flutter#135070) 2023-09-27 tessertaha@gmail.com Fix `SearchAnchor`'s search view isn't updated when the theme changes & widgets inside the search view do not inherit local themes (flutter/flutter#132749) 2023-09-27 godofredoc@google.com Config changes for linux coverage. (flutter/flutter#135604) 2023-09-27 engine-flutter-autoroll@skia.org Roll Packages from 619af75 to 21c2ebb (6 revisions) (flutter/flutter#135602) ...

These values are generated since #135279, but I didn't know to add the new keys to this list to get them to upload. Failed to do so in #135645, I believe the mistake there was putting them in `_kCommonScoreKeys`, which is also used in "E2E" tests, that don't get full trace data, only high level `FrameTiming` packets. Part of #129150

These values are generated since flutter#135279, but I didn't know to add the new keys to this list to get them to upload. Part of flutter#129150

Reverts flutter#135645

) These values are generated since flutter#135279, but I didn't know to add the new keys to this list to get them to upload. Failed to do so in flutter#135645, I believe the mistake there was putting them in `_kCommonScoreKeys`, which is also used in "E2E" tests, that don't get full trace data, only high level `FrameTiming` packets. Part of flutter#129150

…#135645)

Collect generated frame-request-pending stats

dac748d

moffatman changed the title ~~Collect generated frame-request-pending stats~~ Upload generated frame-request-pending stats Sep 28, 2023

moffatman requested a review from jonahwilliams September 28, 2023 04:04

jonahwilliams approved these changes Sep 28, 2023

View reviewed changes

jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 28, 2023

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 28, 2023

Add new keys to fake data test

22cab77

moffatman added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 28, 2023

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 28, 2023

moffatman added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 28, 2023

auto-submit bot merged commit dd341d4 into flutter:master Sep 28, 2023

zanderso added the revert Autorevert PR (with "Reason for revert:" comment) label Sep 28, 2023

auto-submit bot mentioned this pull request Sep 28, 2023

Reverts "Upload generated frame-request-pending stats" #135668

Closed

8 tasks

auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Sep 28, 2023

auto-submit bot pushed a commit that referenced this pull request Sep 28, 2023

Revert "Upload generated frame-request-pending stats (#135645)"

5697c57

This reverts commit dd341d4.

zanderso mentioned this pull request Sep 28, 2023

Revert "Upload generated frame-request-pending stats" #135672

Merged

zanderso added a commit that referenced this pull request Sep 28, 2023

Revert "Upload generated frame-request-pending stats (#135645)"

2549a3b

This reverts commit dd341d4.

zanderso added a commit that referenced this pull request Sep 28, 2023

Revert "Upload generated frame-request-pending stats" (#135672)

63b98d5

Reverts #135645

engine-flutter-autoroll mentioned this pull request Sep 28, 2023

Roll Flutter from f92884c7b846 to 8d01d55bf064 (124 revisions) flutter/packages#5023

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023

dd341d4 Upload generated frame-request-pending stats (flutter/flutter…

3f37c0a

…#135645)

engine-flutter-autoroll mentioned this pull request Sep 28, 2023

Roll Flutter from f92884c7b846 to 449c9279e762 (125 revisions) flutter/packages#5024

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023

dd341d4 Upload generated frame-request-pending stats (flutter/flutter…

6eef245

…#135645)

zanderso mentioned this pull request Sep 28, 2023

revert bot not landing reverts #135670

Closed

engine-flutter-autoroll mentioned this pull request Sep 28, 2023

Roll Flutter from f92884c7b846 to 880a0a1903ae (127 revisions) flutter/packages#5027

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023

dd341d4 Upload generated frame-request-pending stats (flutter/flutter…

daca70c

…#135645)

engine-flutter-autoroll mentioned this pull request Sep 28, 2023

Roll Flutter from f92884c7b846 to 3b19c2e5d83a (128 revisions) flutter/packages#5028

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023

dd341d4 Upload generated frame-request-pending stats (flutter/flutter…

f5352d4

…#135645)

engine-flutter-autoroll mentioned this pull request Sep 28, 2023

Roll Flutter from f92884c7b846 to 6cde5da5ea33 (131 revisions) flutter/packages#5030

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023

dd341d4 Upload generated frame-request-pending stats (flutter/flutter…

66df47e

…#135645)

engine-flutter-autoroll mentioned this pull request Sep 28, 2023

Roll Flutter from f92884c7b846 to 9fdb167183f2 (134 revisions) flutter/packages#5031

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023

dd341d4 Upload generated frame-request-pending stats (flutter/flutter…

18027d0

…#135645)

engine-flutter-autoroll mentioned this pull request Sep 29, 2023

Roll Flutter from ff4a0f676f41 to cfdaf1e593cf (46 revisions) flutter/packages#5035

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 29, 2023

dd341d4 Upload generated frame-request-pending stats (flutter/flutter…

24b5272

…#135645)

engine-flutter-autoroll mentioned this pull request Sep 29, 2023

Roll Flutter from ff4a0f676f41 to 57b5c3cda000 (47 revisions) flutter/packages#5036

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 29, 2023

dd341d4 Upload generated frame-request-pending stats (flutter/flutter…

ea148a8

…#135645)

moffatman mentioned this pull request Oct 3, 2023

Upload frame_request_pending_latency [attempt #2] #135890

Merged

8 tasks

Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023

Revert "Upload generated frame-request-pending stats" (flutter#135672)

5ca2257

Reverts flutter#135645

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023

dd341d4 Upload generated frame-request-pending stats (flutter/flutter…

ed52fa2

…#135645)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Upload generated frame-request-pending stats #135645

Upload generated frame-request-pending stats #135645

Uh oh!

moffatman commented Sep 28, 2023

Uh oh!

jonahwilliams left a comment

Uh oh!

auto-submit bot commented Sep 28, 2023

Uh oh!

auto-submit bot commented Sep 28, 2023

Uh oh!

Uh oh!

Upload generated frame-request-pending stats #135645

Upload generated frame-request-pending stats #135645

Uh oh!

Conversation

moffatman commented Sep 28, 2023

Pre-launch Checklist

Uh oh!

jonahwilliams left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Sep 28, 2023

Uh oh!

auto-submit bot commented Sep 28, 2023

Uh oh!

Uh oh!