-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[camerax] Implements setExposureMode
#6110
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setFocusMode
and setExposureMode
setExposureMode
camsim99
commented
Feb 21, 2024
decodedOptions.put( | ||
CaptureRequestKeySupportedType.values()[option.getKey().intValue()], option.getValue()); | ||
Integer index = ((Number) option.getKey()).intValue(); | ||
decodedOptions.put(CaptureRequestKeySupportedType.values()[index], option.getValue()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a fix for a casting error I got.
11 tasks
gmackall
approved these changes
Feb 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 29, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 29, 2024
flutter/packages@353086c...6d02f03 2024-02-28 engine-flutter-autoroll@skia.org Manual roll Flutter from c30f998 to d00bfe8 (32 revisions) (flutter/packages#6222) 2024-02-28 stuartmorgan@google.com [google_maps_flutter] Add `style` to widget (flutter/packages#6192) 2024-02-28 58529443+srujzs@users.noreply.github.com Add library annotations for js interop (flutter/packages#6216) 2024-02-28 stuartmorgan@google.com [google_map_flutter] Add style to widget - platform impls (flutter/packages#6205) 2024-02-28 brackenavaron@gmail.com [google_maps_flutter_web] Migrate to package:web (flutter/packages#5254) 2024-02-28 737941+loic-sharma@users.noreply.github.com [pigeon] Remove heap allocation in generated C++ code (flutter/packages#6196) 2024-02-27 tarrinneal@gmail.com [pigeon] Allows kotlin generator to skip error class generation (flutter/packages#6183) 2024-02-27 43054281+camsim99@users.noreply.github.com [camerax] Implements `setExposureMode` (flutter/packages#6110) 2024-02-27 engine-flutter-autoroll@skia.org Roll Flutter from b77560e to c30f998 (12 revisions) (flutter/packages#6211) 2024-02-26 pageli328@gmail.com Add `InkResponse`, `Material` and fix `Opacity` (flutter/packages#6199) 2024-02-26 cepadilla@google.com [url_launcher] Add explicit imports of UIKit (flutter/packages#6208) 2024-02-26 737941+loic-sharma@users.noreply.github.com [pigeon] Fix tool hangs on verbose sub-processes (flutter/packages#6198) 2024-02-26 stuartmorgan@google.com [tool] Ignore GeneratedPluginRegistrant.swift for `format` (flutter/packages#6195) 2024-02-26 engine-flutter-autoroll@skia.org Roll Flutter from 1e8dd1e to b77560e (8 revisions) (flutter/packages#6207) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu
pushed a commit
to LouiseHsu/packages
that referenced
this pull request
Mar 7, 2024
Implements `setExposureMode`. Fixes flutter/flutter#120468. ~To be landed after (1) flutter#6059 then (2) flutter#6109 Done :)
auto-submit bot
pushed a commit
that referenced
this pull request
Mar 19, 2024
Implements `setFocusMode` (also adds support for disabling auto-cancel to `FocusMeteringAction` host API implementation to accomplish this) + some minor documentation improvements based on discoveries I made while working on this :) Fixes flutter/flutter#120467. ~To be landed after: #6110 Done :)
11 tasks
arc-yong
pushed a commit
to Arctuition/packages-arc
that referenced
this pull request
Jun 14, 2024
Implements `setExposureMode`. Fixes flutter/flutter#120468. ~To be landed after (1) flutter#6059 then (2) flutter#6109 Done :)
arc-yong
pushed a commit
to Arctuition/packages-arc
that referenced
this pull request
Jun 14, 2024
Implements `setFocusMode` (also adds support for disabling auto-cancel to `FocusMeteringAction` host API implementation to accomplish this) + some minor documentation improvements based on discoveries I made while working on this :) Fixes flutter/flutter#120467. ~To be landed after: flutter#6110 Done :)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
setExposureMode
.Fixes flutter/flutter#120468.
To be landed after (1) #6059 then (2) #6109.Done :)Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).