Skip to content

[image_picker_ios] Update image picker UI test query for iOS 18 #7325

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Aug 6, 2024

The image picker UI changed from iOS 17 -> iOS 18 (beta), and there's an additional scrollview that wasn't present before.
Instead of selecting the first image in the first scroll view, instead select the image with the accessibility label that starts with "Photo":

      ↪︎Find: First Match
        Output: {
          Image, 0x10134f070, {{-0.0, 339.7}, {142.2, 142.3}}, label: 'Photo, March 30, 2018, 12:14 PM'
        }

This works on previous versions of iOS as well.

Fixes flutter/flutter#150220, found in Xcode 16 beta.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman
Copy link
Member Author

jmagman commented Aug 6, 2024

Passes on Xcode 16 beta 4 #7226

** TEST SUCCEEDED **

Testing started
Successfully ran iOS xctest for packages/image_picker/image_picker_ios/example

[packages/image_picker/image_picker_ios completed in 1m 54s]

@jmagman jmagman requested a review from hellohuanlin August 6, 2024 22:44
@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 6, 2024
@auto-submit auto-submit bot merged commit 9ce1570 into flutter:main Aug 6, 2024
76 checks passed
@jmagman jmagman deleted the image-picker-test branch August 6, 2024 22:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: image_picker platform-ios
Projects
None yet
2 participants