Skip to content

Conversation

ValentinVignal
Copy link
Contributor

Fixes flutter/flutter#170574

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

@ValentinVignal ValentinVignal requested a review from chunhtai as a code owner June 13, 2025 07:37
@ValentinVignal ValentinVignal force-pushed the go-router/update-documentation-with-mixin branch from be9af96 to bfbd614 Compare June 13, 2025 17:24
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 17, 2025
@ValentinVignal ValentinVignal force-pushed the go-router/update-documentation-with-mixin branch from bfbd614 to 9ede039 Compare June 18, 2025 01:16
@Piinks Piinks removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 18, 2025
@Piinks
Copy link
Contributor

Piinks commented Jun 18, 2025

Removed autosubmit to help land a couple of changes here without having to ask folks back for changelog merge conflicts. Currently tracking #8352 -> #9245 -> then this one.

(Also working on a better way to avoid these conflicts)

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 19, 2025
@auto-submit auto-submit bot merged commit ca07b70 into flutter:main Jun 19, 2025
78 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 19, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 19, 2025
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Jun 19, 2025
flutter/packages@715a0a5...0ec4053

2025-06-19 engine-flutter-autoroll@skia.org Roll Flutter from
8303a96 to 85a9b4f (93 revisions) (flutter/packages#9457)
2025-06-19 32538273+ValentinVignal@users.noreply.github.com [go_router]
Update sype safe routing topic to use mixin from go_router_builder 3.0.0
(flutter/packages#9422)
2025-06-19 august.oberhauser@swissinfo.ch [go_router] fix:
PopScope.onPopInvokedWithResult not called in branch routes
(flutter/packages#9245)
2025-06-18 10687576+bparrishMines@users.noreply.github.com [pigeon]
Create a message call free InstanceManager when running unit tests
(flutter/packages#9395)
2025-06-18 737941+loic-sharma@users.noreply.github.com [go_router] Use
library prefix for meta (flutter/packages#9434)
2025-06-18 41765610+ahyangnb@users.noreply.github.com [go_router] fix
Popping state and re-rendering scaffold at the same time doesn't update
the URL on web [new] (flutter/packages#8352)
2025-06-18 robert.odrowaz@leancode.pl [camera_avfoundation] Fix
incorrect types in image stream events (flutter/packages#9418)
2025-06-18 stuartmorgan@google.com [go_router_builder] Temporarily
restrict `build` (flutter/packages#9453)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Ortes pushed a commit to Ortes/packages that referenced this pull request Jun 25, 2025
…r_builder 3.0.0 (flutter#9422)

Fixes flutter/flutter#170574

## Pre-Review Checklist

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
mboetger pushed a commit to mboetger/flutter that referenced this pull request Jul 21, 2025
…r#170879)

flutter/packages@715a0a5...0ec4053

2025-06-19 engine-flutter-autoroll@skia.org Roll Flutter from
8303a96 to 85a9b4f (93 revisions) (flutter/packages#9457)
2025-06-19 32538273+ValentinVignal@users.noreply.github.com [go_router]
Update sype safe routing topic to use mixin from go_router_builder 3.0.0
(flutter/packages#9422)
2025-06-19 august.oberhauser@swissinfo.ch [go_router] fix:
PopScope.onPopInvokedWithResult not called in branch routes
(flutter/packages#9245)
2025-06-18 10687576+bparrishMines@users.noreply.github.com [pigeon]
Create a message call free InstanceManager when running unit tests
(flutter/packages#9395)
2025-06-18 737941+loic-sharma@users.noreply.github.com [go_router] Use
library prefix for meta (flutter/packages#9434)
2025-06-18 41765610+ahyangnb@users.noreply.github.com [go_router] fix
Popping state and re-rendering scaffold at the same time doesn't update
the URL on web [new] (flutter/packages#8352)
2025-06-18 robert.odrowaz@leancode.pl [camera_avfoundation] Fix
incorrect types in image stream events (flutter/packages#9418)
2025-06-18 stuartmorgan@google.com [go_router_builder] Temporarily
restrict `build` (flutter/packages#9453)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vashworth pushed a commit to vashworth/packages that referenced this pull request Jul 30, 2025
…r_builder 3.0.0 (flutter#9422)

Fixes flutter/flutter#170574

## Pre-Review Checklist

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: go_router
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[go_router] Go router type safe route topic is outdated
3 participants