Skip to content

Conversation

ValentinVignal
Copy link
Contributor

Part of flutter/flutter#170574

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

@ValentinVignal ValentinVignal requested a review from chunhtai as a code owner June 13, 2025 07:43
@ValentinVignal ValentinVignal changed the title [go_router_builder] Update readme to use mixin `with _$RouteName [go_router_builder] Update readme to use mixin with _$RouteName Jun 13, 2025
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 17, 2025
@auto-submit auto-submit bot merged commit 715a0a5 into flutter:main Jun 17, 2025
78 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 18, 2025
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Jun 18, 2025
flutter/packages@25d4fa4...715a0a5

2025-06-17 32538273+ValentinVignal@users.noreply.github.com
[go_router_builder] Update readme to use mixin `with _$RouteName`
(flutter/packages#9423)
2025-06-17 sokolovskyi.konstantin@gmail.com [rfw] Update tests to no
longer depend on a `Container` pumped via `testWidgets`.
(flutter/packages#9063)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Ortes pushed a commit to Ortes/packages that referenced this pull request Jun 25, 2025
…utter#9423)

Part of flutter/flutter#170574

## Pre-Review Checklist

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
mboetger pushed a commit to mboetger/flutter that referenced this pull request Jul 21, 2025
…r#170808)

flutter/packages@25d4fa4...715a0a5

2025-06-17 32538273+ValentinVignal@users.noreply.github.com
[go_router_builder] Update readme to use mixin `with _$RouteName`
(flutter/packages#9423)
2025-06-17 sokolovskyi.konstantin@gmail.com [rfw] Update tests to no
longer depend on a `Container` pumped via `testWidgets`.
(flutter/packages#9063)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vashworth pushed a commit to vashworth/packages that referenced this pull request Jul 30, 2025
…utter#9423)

Part of flutter/flutter#170574

## Pre-Review Checklist

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: go_router_builder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants