This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[google_maps_flutter] Marker clustering support #6752
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jokerttu
requested review from
cyanglaz,
GaryQian,
ditman and
stuartmorgan-g
as code owners
github-actions
bot
added
p: google_maps_flutter
platform-android
platform-ios
platform-web
labels
This comment was marked as off-topic.
This comment was marked as off-topic.
stuartmorgan-g
suggested changes
Dec 7, 2022
...maps_flutter_platform_interface/lib/src/platform_interface/google_maps_flutter_platform.dart
Outdated
Show resolved
Hide resolved
packages/google_maps_flutter/google_maps_flutter_platform_interface/lib/src/types/cluster.dart
Outdated
Show resolved
Hide resolved
packages/google_maps_flutter/google_maps_flutter_platform_interface/lib/src/types/cluster.dart
Outdated
Show resolved
Hide resolved
...oogle_maps_flutter/google_maps_flutter_platform_interface/lib/src/types/cluster_manager.dart
Outdated
Show resolved
Hide resolved
...es/google_maps_flutter/google_maps_flutter_platform_interface/lib/src/types/info_window.dart
Outdated
Show resolved
Hide resolved
...oogle_maps_flutter/google_maps_flutter_platform_interface/lib/src/types/cluster_manager.dart
Show resolved
Hide resolved
packages/google_maps_flutter/google_maps_flutter/example/pubspec.yaml
Outdated
Show resolved
Hide resolved
packages/google_maps_flutter/google_maps_flutter/lib/src/controller.dart
Outdated
Show resolved
Hide resolved
...ges/google_maps_flutter/google_maps_flutter_android/lib/src/google_maps_flutter_android.dart
Outdated
Show resolved
Hide resolved
|
@jokerttu FYI one of the change requested was not marked as resolved but it was |
cyanglaz
suggested changes
Jan 19, 2023
packages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/ClusterManagersController.h
Outdated
Show resolved
Hide resolved
packages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/ClusterManagersController.h
Outdated
Show resolved
Hide resolved
packages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/ClusterManagersController.m
Outdated
Show resolved
Hide resolved
packages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/ClusterManagersController.m
Outdated
Show resolved
Hide resolved
packages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/ClusterManagersController.m
Outdated
Show resolved
Hide resolved
packages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/GoogleMapMarkerController.m
Outdated
Show resolved
Hide resolved
packages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/ClusterManagersController.m
Outdated
Show resolved
Hide resolved
packages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/ClusterManagersController.m
Outdated
Show resolved
Hide resolved
packages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/GoogleMapController.m
Show resolved
Hide resolved
packages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/GoogleMapMarkerController.h
Outdated
Show resolved
Hide resolved
cyanglaz
reviewed
Jan 19, 2023
reidbaker
reviewed
Jan 26, 2023
packages/google_maps_flutter/google_maps_flutter/example/lib/clustering.dart
Show resolved
Hide resolved
packages/google_maps_flutter/google_maps_flutter/example/lib/clustering.dart
Show resolved
Hide resolved
packages/google_maps_flutter/google_maps_flutter/example/lib/clustering.dart
Show resolved
Hide resolved
packages/google_maps_flutter/google_maps_flutter/example/lib/clustering.dart
Show resolved
Hide resolved
packages/google_maps_flutter/google_maps_flutter_android/example/lib/clustering.dart
Show resolved
Hide resolved
packages/google_maps_flutter/google_maps_flutter_android/example/pubspec.yaml
Show resolved
Hide resolved
...es/google_maps_flutter/google_maps_flutter_android/lib/src/google_map_inspector_android.dart
Show resolved
Hide resolved
...maps_flutter_platform_interface/lib/src/platform_interface/google_maps_flutter_platform.dart
Show resolved
Hide resolved
...maps_flutter/google_maps_flutter_platform_interface/lib/src/types/utils/cluster_manager.dart
Show resolved
Hide resolved
packages/google_maps_flutter/google_maps_flutter_platform_interface/lib/src/types/marker.dart
Outdated
Show resolved
Hide resolved
* Adds initial marker clustering support for Android, iOS and Web
jokerttu
force-pushed
the
google_maps_flutter_cluster_support
branch
from
4d99d2c to
a8efc71
Compare
reidbaker
approved these changes
Feb 3, 2023
…s for iOS * Rename init method * Improvements * Combine marker handling * Add documentation for cluster tap and consume click * Improve on cluster tap handling * Improve how markers are added or removed from cluster * Remove public methods for single add, delete and change * Add ref for integral zoom * Move marker and cluster manager id handling to category * Fix headers for podspec
jokerttu
requested review from
stuartmorgan-g and
cyanglaz
and removed request for
ditman and
stuartmorgan-g
jokerttu
requested review from
stuartmorgan-g and
cyanglaz
and removed request for
cyanglaz and
stuartmorgan-g
|
All pending CRs have been now fixed. |
|
I think my approval counts for Android |
|
@jokerttu we're using your PR right now and encountered that we cannot define a custom Cluster-Icon...will this also be available with this PR? For Android for example you'll find here the implementation: https://github.com/googlemaps/android-maps-utils/blob/main/library/src/main/java/com/google/maps/android/clustering/view/DefaultClusterRenderer.java#L81 |
|
We've just completed the migration of the plugin code to the flutter/packages repository, as described in https://flutter.dev/go/flutter-plugins-repo-migration, and this repository is now being archived. Unfortunately that means that all in-progress PRs here must be moved to flutter/packages. Please see our instructions for an explanation of how to move your PR, and if you have any issues moving your PR please don't hesitate to reach out in the #hackers-ecosystem channel in Discord. Our apologies that your PR was caught in this one-time transition. We're aware that it's disruptive in the short term, and appreciate your help in getting us to a better long-term state! |
11 tasks
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the initial support for the marker clustering for Android, iOS and Web platforms.
Clustering is implemented using native google maps utils libraries for Android, iOS and Web.
Android:
iOS:
Web:
Resolves flutter/flutter#26863
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.