Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix to videos recorded with an orientation of 180° ( landscapeRight) being reversed on Android #646

Merged
merged 2 commits into from
Jun 16, 2022
Merged

Fix to videos recorded with an orientation of 180° ( landscapeRight) being reversed on Android #646

merged 2 commits into from
Jun 16, 2022

Conversation

williamviktorsson
Copy link
Contributor

@williamviktorsson williamviktorsson commented Jun 14, 2022 •
edited
Loading

Dependency updates to latest versions as of 2022-06-14.

Most importantly it includes video_player 2.4.4 which solves the issue of landscape mode videos captured in (landscapeRight) being rotated 180 degrees on android.

Relevant issue: flutter/flutter#60327

@williamviktorsson williamviktorsson changed the title version updates Fix to videos recorded with an orientation of 180° ( landscapeRight) being reversed on Android Jun 14, 2022
@williamviktorsson
Copy link
Contributor Author

I'll be using this for the time being as my clients have been eager to see this bug from june 2020 being fixed :-)

dependencies:
  chewie:
    git:
      url: https://github.com/WilliamViktorsson/chewie.git

@diegotori
Copy link
Collaborator

@williamviktorsson Thanks for the PR. Please revert the version name change, since I'll take care of that when I create a new release tonight or this week.

@williamviktorsson
Update pubspec.yaml
8109092 
revert version up
@williamviktorsson
Copy link
Contributor Author

@williamviktorsson Thanks for the PR. Please revert the version name change, since I'll take care of that when I create a new release tonight or this week.

Done!

@diegotori
Copy link
Collaborator

@williamviktorsson LGTM. Once the automated checks pass, then I'll merge to master. Will cut a build either tonight or this weekend.

@diegotori diegotori merged commit 12d865c into fluttercommunity:master Jun 16, 2022
diegotori added a commit that referenced this pull request Jun 21, 2022
@diegotori
Version 1.3.4. Addresses PRs #623 and #646.
3948d23
codenameakshay pushed a commit to qoohoo-app/chewie that referenced this pull request Aug 29, 2022
@diegotori @codenameakshay
Version 1.3.4. Addresses PRs fluttercommunity#623 and fluttercommunit…
2f4d7bd 
…y#646.
lg8294 added a commit to lg8294/chewie that referenced this pull request Sep 22, 2022
@lg8294
Merge commit '3948d23733638d8a58ea5ff065abfe96934d2373' into custom-lg
2e3d579 
* commit '3948d23733638d8a58ea5ff065abfe96934d2373': (110 commits)
  Version 1.3.4. Addresses PRs fluttercommunity#623 and fluttercommunity#646.
  Update pubspec.yaml
  version updates
  fix: change video type
  fix: format and migration artifacts
  fix: apply diegotori suggestion
  feat: added support for apple and desktop version
  feat: Make progressIndicatorDelay a Duration
  fix: simplify assignation
  fix: name
  fix: let the android player buffer before seeking once more
  fix: removed old code
  fix: lint
  feat: added method to set progress delay
  feat: added example debug
  feat: add a delay before displaying progress indicator
  Version 1.3.3. Adds PR fluttercommunity#634.
  Update pubspec.yaml
  chore: remove unused dependency
  Version 1.3.2. Adds PR fluttercommunity#626.
  ...

# Conflicts:
#	example/ios/Runner.xcodeproj/project.pbxproj
#	example/ios/Runner.xcodeproj/xcshareddata/xcschemes/Runner.xcscheme
#	example/ios/Runner/Info.plist
#	example/lib/main.dart
#	example/pubspec.yaml
#	lib/src/chewie_player.dart
#	pubspec.yaml
@Hamdan85
Copy link

guys, this is still happening! FYI

@diegotori
Copy link
Collaborator

@Hamdan85 if this is still happening on Android, then please raise an issue with the Flutter team related to video_player.

Keep in mind that Chewie is merely a UI layer over VideoPlayer. If this issue is still persisting, then bring it up with them so that it gets addressed on their end. Thanks.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@williamviktorsson @diegotori @Hamdan85