Fix FormatException on latest flutter configuration files #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing this error on new flutter configs
```
════════════════════════════════════════════
FLUTTER LAUNCHER ICONS (v0.9.1)
════════════════════════════════════════════
✓ Successfully generated launcher icons
Unhandled exception:
FormatException: Invalid number (at character 1)
^
#0 int._handleFormatError (dart:core-patch/integers_patch.dart:129:7)
fluttercommunity#1 int.parse (dart:core-patch/integers_patch.dart:55:14)
fluttercommunity#2 minSdk (package:flutter_launcher_icons/android.dart:309:18)
fluttercommunity#3 createIconsFromConfig (package:flutter_launcher_icons/main.dart:94:47)
fluttercommunity#4 createIconsFromArguments (package:flutter_launcher_icons/main.dart:60:7)
fluttercommunity#5 main (file:///Users/marcobazzani/Projects/flutter_launcher_icons/bin/main.dart:6:26)
fluttercommunity#6 _delayEntrypointInvocation.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:295:32)
fluttercommunity#7 _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:192:12)
```
|
Is just catching the exception a suitable resolution? Shouldn't an attempt be made to reference the value stored at |
|
@oravecz-jpmc you are right but I don't know where to get it and there was already a logic "assume the worst" so I continued into that path. The real question here is why the sdk version is needed for a library that shoud just convert image formats. I don't get it |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing this error on new flutter configs