Return the instance when calling registerSingleton

[Rexios80]

Just a convenience feature so you can write code like this:

final instance = GetIt.I.registerSingleton(Object());

[escamoteur]

Hi, sorry for not looking into this earlier, but I had some mental health problems the last half year.

Why do you think this is better than

final instance = Object();

GetIt.I.registerSingleton(instance);

[Rexios80]

It's mostly for convenience, but it also lets you register a singleton like this:

class Class {
    final instance = GetIt.I.registerSingleton(Object());
}

Which isn't possible otherwise

[escamoteur]

I see, but why do you store the instance at all outside of get_it? Am 3. Feb. 2022, 19:01 +0100 schrieb Rexios ***@***.***>:

…

It's mostly for convenience, but it also lets you register a singleton like this: class Class { final instance = GetIt.I.registerSingleton(Object()); } Which isn't possible otherwise — Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you commented.Message ID: ***@***.***>

[Rexios80]

For myself I use it for more convenient initialization of the singleton:

final instance = GetIt.I.registerSingleton(Object());
instance.setup();
instance.doOtherStuff();

Not a huge deal to split the first line into two, but again this is just for convenience.

[escamoteur]

@esDotDev What do you think?

[esDotDev]

I think darts chaining ability makes this a bit redundant.

final instance = Object()..setup()..doOtherStuff();
GetIt.I.registerSingleton(instance);

On the other hand, it cant really hurt, and is a small quality of life thing, so why not?

[escamoteur]

What I don't like is that it would break the format of the other registerFunctions.

[Rexios80]

Couldn't we make those do the same thing?

[escamoteur]

Unfortunately no, because all the registerFuncions that take a factoryfuncion return without creating an instance

[esDotDev]

I think if it's lazy, it's obvious why it wouldn't return anything. Seems ok to me.

[esDotDev]

If we did want to have similar functionality lazily, an onCreated: (instance){ } method could be nice?

[Rexios80]

Just a random thought: you can't await chained async calls

[escamoteur]

I know this is a pretty old PR but I had to make a break over the last year