Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add the pr string to suffix #1003

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Add the pr string to suffix #1003

merged 1 commit into from
Sep 19, 2023

Conversation

chanwit
Copy link
Collaborator

@chanwit chanwit commented Sep 19, 2023

A previous fix removed the branch name out of the object name, making
the object name harder to read. For example hello-tf became hello-tf-1.

This PR added the pr string to the suffix, resulting in the object
name hello-tf-pr-1. This makes it easier to discern that this object
corresponds to Pull Request 1 for example.

Fixes #1000

Must merge after #1001

A previous fix removed the branch name out of the object name, making
the object name harder to read. For example `hello-tf` became `hello-tf-1`.

This PR added the `pr` string to the suffix, resulting in the object
name `hello-tf-pr-1`. This makes it easier to discern that this object
corresponds to Pull Request 1 for example.

Signed-off-by: Chanwit Kaewkasi <chanwit@gmail.com>
@chanwit chanwit force-pushed the add-pr-string-to-suffix branch from a9176a1 to f27e67d Compare September 19, 2023 08:44
@chanwit chanwit merged commit a65b947 into main Sep 19, 2023
@bigkevmcd bigkevmcd deleted the add-pr-string-to-suffix branch December 12, 2023 17:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Branch planner objects now contain PR ID only and they are hard to read
2 participants