Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: Drop deprecated io/ioutil #964

Merged
merged 1 commit into from
Jul 31, 2021
Merged

Conversation

shuheiktgw
Copy link
Contributor

Removed deprecated io/ioutil from the source code. Thank you for your review!
Ref: fluxcd/flux2#1658

@shuheiktgw shuheiktgw requested a review from stefanprodan as a code owner July 30, 2021 23:25
Signed-off-by: shuheiktgw <shuheiktgw@users.noreply.github.com>
@codecov-commenter
Copy link

Codecov Report

Merging #964 (38d3ca1) into main (df459c5) will not change coverage.
The diff coverage is 52.94%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #964   +/-   ##
=======================================
  Coverage   56.91%   56.91%           
=======================================
  Files          71       71           
  Lines        5861     5861           
=======================================
  Hits         3336     3336           
  Misses       2030     2030           
  Partials      495      495           
Impacted Files Coverage Δ
pkg/loadtester/concord.go 29.03% <0.00%> (ø)
pkg/notifier/client.go 31.42% <0.00%> (ø)
pkg/loadtester/server.go 12.94% <14.28%> (ø)
pkg/controller/webhook.go 64.70% <100.00%> (ø)
pkg/loadtester/task_ngrinder.go 48.14% <100.00%> (ø)
pkg/metrics/providers/datadog.go 63.38% <100.00%> (ø)
pkg/metrics/providers/graphite.go 61.61% <100.00%> (ø)
pkg/metrics/providers/newrelic.go 59.37% <100.00%> (ø)
pkg/metrics/providers/prometheus.go 63.63% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df459c5...38d3ca1. Read the comment docs.

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @shuheiktgw 🥇

@stefanprodan stefanprodan merged commit e2b08eb into fluxcd:main Jul 31, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants