Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

loader: allow overwrite of URL hostname again #844

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Conversation

hiddeco
Copy link
Member

@hiddeco hiddeco commented Dec 13, 2023

This adds back the support for overwriting the host name a chart is downloaded from (again) using the SOURCE_CONTROLLER_LOCALHOST environment variable.

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This adds back the support for overwriting the host name a chart is
downloaded from (again) using the `SOURCE_CONTROLLER_LOCALHOST`
environment variable.

Signed-off-by: Hidde Beydals <hidde@hhh.computer>
@hiddeco hiddeco force-pushed the sc-hostname-overwrite branch from c98f4de to 1e66201 Compare December 13, 2023 08:35
@hiddeco hiddeco merged commit 259b8f8 into main Dec 13, 2023
10 checks passed
@hiddeco hiddeco deleted the sc-hostname-overwrite branch December 13, 2023 08:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants