Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add InclusionList to Alert CRD #515

Merged
merged 1 commit into from
May 3, 2023

Conversation

matheuscscp
Copy link
Member

@matheuscscp matheuscscp commented Apr 29, 2023

Fixes #512

Not sure if this is API v1beta2 or v1.

@matheuscscp matheuscscp force-pushed the inclusion-list branch 3 times, most recently from 489016f to 48ad753 Compare April 30, 2023 14:35
@matheuscscp matheuscscp marked this pull request as ready for review April 30, 2023 14:37
@stefanprodan stefanprodan added enhancement New feature or request area/alerting Alerting related issues and PRs labels May 2, 2023
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
Co-authored-by: Stefan Prodan <stefan.prodan@gmail.com>
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @matheuscscp 🥇

@stefanprodan stefanprodan merged commit f798c76 into fluxcd:main May 3, 2023
@matheuscscp matheuscscp deleted the inclusion-list branch May 3, 2023 09:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area/alerting Alerting related issues and PRs enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Add inclusion list to Alert CRD
2 participants