Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ssa: Fix Secrets diff by converting StringData to Data #235

Merged
merged 1 commit into from
Feb 18, 2022

Conversation

souleb
Copy link
Member

@souleb souleb commented Feb 9, 2022

If applied, will make sure that stringData is converted to Data before
applying.

Signed-off-by: Soule BA bah.soule@gmail.com

@souleb souleb marked this pull request as draft February 9, 2022 16:13
@souleb souleb force-pushed the fix-stringdata-diff branch 5 times, most recently from f6b02ff to c5bee3e Compare February 9, 2022 17:35
@souleb souleb force-pushed the fix-stringdata-diff branch 2 times, most recently from d084deb to 56f7b29 Compare February 17, 2022 14:27
@souleb souleb marked this pull request as ready for review February 17, 2022 14:51
@souleb souleb requested a review from stefanprodan February 17, 2022 17:15
@stefanprodan stefanprodan added the area/server-side-apply SSA related issues and pull requests label Feb 18, 2022
@stefanprodan stefanprodan changed the title convert StringData to data ssa: Fix Secrets diff by converting StringData to Data Feb 18, 2022
If applied, will make sure that stringData is converted to Data before
applying.

Signed-off-by: Soule BA <bah.soule@gmail.com>
@souleb souleb force-pushed the fix-stringdata-diff branch from 56f7b29 to 94fc3ea Compare February 18, 2022 08:43
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @souleb 🏅

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area/server-side-apply SSA related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants