http/fetch: improve error messages #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
force-pushed
the
fetch-improve-err
branch
from
91ed6ac to
1e89569
Compare
makkes
reviewed
May 10, 2023
- Return a more specific error for an empty digest, instead of a parsing error. - Include the digest in the error message when parsing fails. - Tidy the format of some other errors. Signed-off-by: Hidde Beydals <hidde@hhh.computer>
hiddeco
force-pushed
the
fetch-improve-err
branch
from
1e89569 to
7916c22
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would have helped with fluxcd/flux2#3861.